Add debug restart #508
Draft
Add debug restart #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a nice improvement on the HCR failure path. Now that I appreciate the use case better... I can also appreciate that it still leaves say the path in which dev mode restarts the server upon a bootstrap.properties update. Let's think about that more. |
awisniew90
force-pushed
the
debug-restart
branch
5 times, most recently
from
cd61919
to
5ce2066
Compare
scottkurz
reviewed
Aug 13, 2024
bundles/io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/DevModeOperations.java
Outdated
Show resolved
Hide resolved
| /** | ||
| * Updates the state of this target for disconnection from the VM. | ||
| */ | ||
| @Override |
There was a problem hiding this comment.
Maybe a comment explaining we don't know here if we're disconnected() because of dev mode restarting the server vs. the JDT debugger HCR failure refreshing the debugger.
| port = parts[1].trim(); | ||
| String lastEntry = null; | ||
|
|
||
| Scanner scan = new Scanner(serverEnv); |
There was a problem hiding this comment.
Turns out we don't need to make this change.
...io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/debug/DebugModeHandler.java
Outdated
Show resolved
Hide resolved
...io.openliberty.tools.eclipse.ui/src/io/openliberty/tools/eclipse/debug/DebugModeHandler.java
Outdated
Show resolved
Hide resolved
awisniew90
force-pushed
the
debug-restart
branch
from
5ce2066
to
5c608df
Compare
Signed-off-by: Adam Wisniewski <awisniew@Adams-MacBook-Pro.local>
awisniew90
force-pushed
the
debug-restart
branch
from
5c608df
to
c95e3ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #498
This PR creates the following behaviors: