-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate performance slowdown when editing server.xml #329
Labels
Comments
TrevCraw
changed the title
Investigate performance degradation with editing in server.xml
Investigate performance slowdown when editing server.xml
Apr 12, 2024
Next steps, as recommended by @gjdeval:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Related to OpenLiberty/liberty-tools-intellij#687
We have observed performance slowdown with completion and hover both inside and outside of the
featureManager
section of theserver.xml
. There is a clear difference when moving from LT VS Code 23.0.6 to LT VS Code 23.0.9.v23.0.6 contains LCLS 2.0 and v23.0.9 contains LCLS 2.0.1.
We have been able to consistently reproduce the slowdown on @mrglavas's Windows development machine as well as a Windows VM owned by @dessina-devasia and @aparnamichael.
This slowdown is observed in the latest releases of LT IntelliJ (24.0.3) and LT Eclipse (24.0.3) as well. The slowdown started in v24.0.3 for LT IntelliJ, and either v23.0.9 or v23.0.12 for LT Eclipse (some discrepancies in results between the two machines).
Attached is trace from the XML Support output in VS Code when invoking completion outside the
featureManager
section for the second time inserver.xml
with v23.0.6 and v.23.0.9. Both tests were with the same project and an existingtarget
folder. The key line in the trace is line 34 showing v23.0.9 taking more than twice as long as v23.0.6.23.0.6-VSCode-trace.txt
23.0.9-VSCode-trace.txt
Change set for LT VS Code 23.0.9 vs 23.0.6: 23.0.6...23.0.9. One change of note is #286, although this code path was not supposed to be used for 23.0.9. It was intended for supporting LCLS 2.1.
Change set for LCLS 2.0.1 vs 2.0: OpenLiberty/liberty-language-server@liberty-langserver-2.0...lemminx-liberty-2.0.1
The text was updated successfully, but these errors were encountered: