Reconsume latest MicroProfile Config 2.0 snapshot

[tevans78]

https://repo1.maven.org/maven2/org/eclipse/microprofile/config/microprofile-config-api/2.0-M1/microprofile-config-api-2.0-M1.jar

If the RC1 API is available then we should use that instead

[Azquelt]

With the 2.0 M1 API + a snapshot smallrye impl, we have the following tests failing:

Config 1.2 FAT bucket FULL (from 22 tests):

• converterPrioritySPITest_CONFIG20_EE8
  (Fixed with: Fix Converter Priority and add unit test smallrye/smallrye-config#386)

• optionalConverterTest_CONFIG20_EE8
  (Fixed with: Fix #409 - Properly validate all injections points, instead of returning after a property that should not be validated is found. smallrye/smallrye-config#412. Also resolved by Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375 by updating the test's converter to match spec-"if a converter detects an empty value it must return null").

Config 1.1 FAT bucket FULL (from 314 tests):

• testPizza_CONFIG20_EE8
  (Issue for this: Clarify when defaultValue is used on ConfigProperty eclipse/microprofile-config#608)

• testNullWithDefault_CONFIG20_EE8
  (Issue for this: Clarify when defaultValue is used on ConfigProperty eclipse/microprofile-config#608)

• defaultsMixedOrdinals_CONFIG20_EE8
  (Fixed with: Fix #401 - Support config_ordinal in Env and Sys Config Sources. smallrye/smallrye-config#403)

• defaultsOrdinalFromSource_CONFIG20_EE8
  (Fixed with: Fix #401 - Support config_ordinal in Env and Sys Config Sources. smallrye/smallrye-config#403)

• testCurrency_CONFIG20_EE8
  (Fixed with: 342 343 - add Currency and Bitset converters smallrye/smallrye-config#390)

• testBitSet_CONFIG20_EE8
  (Fixed with: 342 343 - add Currency and Bitset converters smallrye/smallrye-config#390)

• testMethodUnnamed_CONFIG20_EE8, testConstructorUnnamed_CONFIG20_EE8
  (Fixed with: Keep validating if injection point name missing smallrye/smallrye-config#424. Also resolved by Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375 by moving tests to 2.0 FAT bucket to check for new output Strings)

• testLargeConfigSources_CONFIG20_EE8, testLargeDynamicUpdates_CONFIG20_EE8, testOrdinalsCustomSources_CONFIG20_EE8
  (Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375. MySource() had an unimplemented method getPropertyNames() which had its default implementation removed from mpConfig 1.4 -> 2.0)

• testNonExistantKey_CONFIG20_EE8
  (Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375. Moved test to 2.0 FAT bucket to check for new output String)

• testDogConverterMissing_CONFIG20_EE8
  (Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375. Moved test to 2.0 FAT bucket to check for new output String. Also renamed test to testConverterMissing())

• defaultsGetConfigPathProcEnv_CONFIG20_EE8
  (Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375. Moved test to 2.0 FAT bucket to check for new output Strings, and renamed to defaultSystemConfigProperties())

• testUserLoaderErrors_CONFIG20_EE8, testConverterExceptions_CONFIG20_EE8
  (Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375. Moved tests to 2.0 FAT bucket to check for new output String, also, mpConfig > 1.4 doesn't throw generate FFDC, so @ExpectedFFDC in 1.1 bucket was creating an issue)

• testSimpleString_CONFIG20_EE8, testDiscovered_CONFIG20_EE8, testOPTIONAL_CONFIG20_EE8, testGenericInstance_CONFIG20_EE8, testGenericProvider_CONFIG20_EE8, testDefault_CONFIG20_EE8, testOPTIONAL_MISSING_CONFIG20_EE8, testNamed_CONFIG20_EE8, testDog_CONFIG20_EE8, testGoodPizza_CONFIG20_EE8, testOPTIONAL_NULL_CONFIG20_EE8
  (Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375. These tests were never broken, but were failing as a byproduct of other failing tests)

• testAnimal_CONFIG20_EE8, testParent_CONFIG20_EE8, testConverterSubclass_CONFIG20_EE8
  (Keeping disabled- MP Config doesn't require the functionality to derive converters from parent/child classes. Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375 by disabling by moving to libertyTests package in 1.1 FAT bucket which only runs against mpConfig < 2.0)

• testPartialPizza_CONFIG20_EE8
  (Keeping disabled- The MP Config spec was updated from 1.4 -> 2.0 such that an "Empty string as the default value will be ignored, which is same as not setting the default value". Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375 by disabling by moving to libertyTests package in 1.1 FAT bucket which only runs against mpConfig < 2.0)

• testAtomicLong_CONFIG20_EE8, testAtomicInteger_CONFIG20_EE8
  (Keeping disabled- SmallRye aren't going to have these converters as defaults. Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375 by disabling by moving to libertyTests package in 1.1 FAT bucket which only runs against mpConfig < 2.0)

• testClassLoaderCache_CONFIG20_EE8, testMultiApplication_CONFIG20_EE8
  (Keeping disabled- SmallRye implementation doesn't have methods for accessing cache for ConfigProviderResolver. e.g. getConfigCacheSize(). Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375 by not repeating against mpConfig > 1.4 in ClassLoaderCacheTest())

• testClosedConfigStopsRefreshing_CONFIG20_EE8, testDynamicTiming_CONFIG20_EE8
  (Keeping disabled- Polling behaviour changed from mpConfig 1.4 -> 2.0. Resolved with this PR: Fix MP Config FAT tests so they can run against mpConfig 2.0 #14375 by not repeating against mpConfig > 1.4 in DynamicSourcesTest())

[tevans78]

The tests above have now been disabled so that we can attempt to get into the next beta. Emily and I have been through the failures and there probably isn't anything concerning/unexpected for beta level code.

[tevans78]

Using RC1 API and TCK with a snapshot build SmallRye Config, as of 1st Oct, these are now the failing TCKs;
Tests: 368 Failures: 16 Errors: 19

[junit]                                multipleExpressions
[junit]                                defaultExpressionComposedEmpty
[junit]                                noExpressionComposed
[junit]                                arrayEscapes
[junit]                                expressionMissing
[junit]                                noExpression
[junit]                                infiniteExpansion
[junit]                                defaultExpressionComposed
[junit]                                defaultExpression
[junit]                                escape
[junit]                                escapeBraces
[junit]                                composedExpressions
[junit]                                defaultExpressionEmpty
[junit]                                simpleExpression
[junit]                                multipleExpansions
[junit]                                testInjectedConfigSerializable
[junit]                                testConfigProfileWithDev
[junit]                                testConfigPropertiesNoPrefixOnBean
[junit]                                testNoConfigPropertiesAnnotationInjection
[junit]                                testConfigPropertiesWithoutPrefix
[junit]                                testConfigPropertiesPlainInjection
[junit]                                testConfigPropertiesDefaultOnBean
[junit]                                testConfigPropertiesNoPrefixOnBeanThenSupplyPrefix
[junit]                                testConfigPropertiesWithPrefix
[junit]                                testConfigProfileWithDev
[junit]                                testConfigProfileWithDev
[junit]                                expression
[junit]                                expressionNoDefault
[junit]                                testConfigProfileWithDev
[junit]                                configValueInjection
[junit]                                configValueEmpty
[junit]                                configValue
[junit]                                test
[junit]                                testConfigProfileWithDev
[junit]                                testConfigProfileWithDev

[Azquelt]

Running with the latest snapshots of smallrye-config and the TCK, I have the following problems:

Multiple tests have beans which are static inner classes of the test class. The test class and its inner classes are included in the .jar (which has a beans.xml), and then automatically added by arquillian to the .war as well (which has no beans.xml). Liberty sees both classes, makes them beans and then gets an ambiguous bean exception. We might be able to fix this with minimal changes by adding a beans.xml with bean-discovery-mode="none" to the .war so that Liberty doesn't pick up the class in the .war as a bean.

This problem affects multiple classes:

ConfigPropertyFileProfileTest
ProdProfileTest
ConfigProviderTest
InvalidConfigProfileTest
DevConfigProfileTest
ConfigValueTest
TestCustomConfigProfile
TestConfigProfileTest

For PropertyExpressionsTest, expressions do not get resolved because OLSmallRyeConfigProviderResolver.getBuilder() does not add the default interceptors when creating the builder (contrast with SmallRyeConfigProviderResolver).

Once this problem is fixed, PropertyExpressionsTest still fails because the @AfterMethod call runs on both the client and server, and when it runs on the client, the MP Config Impl is not available.

[tevans78]

This was completed