-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add links to Guides and Get Started page in Footer #3808
Comments
@SteveSamJacob19 Can you please assign this issue to me ? |
@pranay911 Sure |
@SteveSamJacob19 Can you please send me the link ? |
The header contains the links to "Guides" and "Get Started" pages, you can obtain it from there and just add it to the footer like how the "Docs", "Blogs" and "Support" are in the footer |
@pranay911 Whats the status on this? |
Hello @SteveSamJacob19, can you assign this issue to me? I would like to contribute |
@JavierABarreto Sure, please do go through our wiki on how to contribute before creating a pull request |
Hi @SteveSamJacob19, following the How to Contribute guide I tried to push the changes into the repo but it returned me an error: Do I need permission to perform a push? Or it is better if I do a fork and create the PR from there? |
Hi @JavierABarreto are you able to push your changes to your branch now? |
Hi @SteveSamJacob19, I tried to push my changes but it still gives me an error: |
Hi @JavierABarreto, Can you tell me the exact steps you've taken and to which branch you're pushing the changes to? |
Hi @SteveSamJacob19, yes what I did was:
|
Did you clone the branch using SSH? If not can you try that? |
Hi @SteveSamJacob19, I cloned the branch again this time using SSH, created the branch adding-links-in-foote again, and I still can't push my changes. |
Ok, can you fork the Repo and push changes? |
Hi @SteveSamJacob19, when I create the PR to draft, id adds some commits and files that aren't mine, is it because draft is not up to date with prod? |
Hi @JavierABarreto , you have to rebase your branch to draft and then create a PR |
Hi @SteveSamJacob19, I created the branch from prod, rebased with draft, added my changes and then created the PR and it still has some commits/files that aren't mine. I will work on that and on solving conflicts. |
Hi @JavierABarreto, Can you create the PR anyways, ill look into it |
@JavierABarreto I think you will have to fetch our repo upstream to ur forked repo and then "rebase" to draft and not merge draft. |
That's actually what I did, gotta do it again to make sure that I didn't missed any step while "Rebasing" |
Yup, it seems that I had to skip some commits while rebasing draft lol, there we go. |
Hi @SteveSamJacob19, while reviewing the changes on the draft view I noticed that there's this small detail where the div of the links do this: My question is, do I change it? and if I do, may I modify this media line to 910px? Modifying this media line to 910px would make this look better. |
@JavierABarreto I will have to discuss on this and get back to you |
Hi @SteveSamJacob19, then I do the PR to staging? or I wait for your answer? |
Hi @JavierABarreto you can continue with the change into draft and only then move to staging cause it does look odd |
Hi @JavierABarreto please add me as a reviewer whenever you open a PR and also ensure that its rebased. I have done both this time but ensure the same when ur create a PR to staging |
Hi @SteveSamJacob19, I have tried before to add you as a reviewer but it doesn't let me (it seems that I lack perms on adding who can review my PRs) |
Hello @SteveSamJacob19, I created the PR to staging and it doesn't let me add anyone as a reviewer |
@JavierABarreto Thats fine, i will take a look into the PR as soon as im free and push it if its correct |
The footer has to be updated by adding the links to Guides and Get Started page to maintain consistency with the Header. This does not have much user impact and hence can be considered low priority
The text was updated successfully, but these errors were encountered: