Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Current mass scaling in flight_phase_builder is not ideal. #607

Open
Kenneth-T-Moore opened this issue Nov 18, 2024 · 0 comments
Open

Current mass scaling in flight_phase_builder is not ideal. #607

Kenneth-T-Moore opened this issue Nov 18, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Kenneth-T-Moore
Copy link
Member

Description

Currently, the mass state is added in flight_phase_builder.py with a ref of 1e4 and a defect _ref of 1e6.

  1. I think these are actually switched from what they should be. The 1e6 on the defect ref means the optimizer doesn't see the mass defects as important as other defects. We have had some success in Jes's detailed take-off case with using a smaller value (1e3), so that when the optimizer couldn't satisfy all the constraints, it didn't leave you with large mass discontinuities.
  2. These values are hardcoded, and it would be beneficial for them to be added to the phase_info parameters so that a user can control them directly.

Example

Contact Ken and Jes for specific cases, though item 2 above can be done without one.

Aviary Version

0.9.4-dev

Relevant environment information

No response

@Kenneth-T-Moore Kenneth-T-Moore added the bug Something isn't working label Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant