Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TimeseriesOutputComp allocates memory unnecessarily #1095

Closed
robfalck opened this issue Aug 12, 2024 · 0 comments · Fixed by #1096
Closed

TimeseriesOutputComp allocates memory unnecessarily #1095

robfalck opened this issue Aug 12, 2024 · 0 comments · Fixed by #1096
Assignees
Labels
bug Something isn't working

Comments

@robfalck
Copy link
Contributor

Description

TimeseriesOutputComp calls lagrange_matrices and saves the resulting interpolation and differentiation matrices even if they are not needed.

In the most common use case where a timeseries does no interpolation and computes no rates, these matrices are not necessary.

Furthermore, when differentiation matrices are not needed, we should skip their computation since they can be expensive when segments have a large number of discretization nodes, as is the case with Birkhoff transcription.

Example

N/A

Dymos Version

1.11.1-dev

Relevant environment information

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant