Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parameters from timeseries by default. #911

Closed
robfalck opened this issue Mar 14, 2023 · 1 comment · Fixed by #918
Closed

Remove parameters from timeseries by default. #911

robfalck opened this issue Mar 14, 2023 · 1 comment · Fixed by #918

Comments

@robfalck
Copy link
Contributor

robfalck commented Mar 14, 2023

Proposed feature.

Parameters have been included in the timeseries outputs by default for some time. This was done to maintain consistency with older versions of Dymos. However, this adds a lot of data without much benefit (seeing values of the parameters across all nodes in a phase isn't necessary, since parameters are static.

Parameter values have been available as outputs from dymos phases for several releases now as f'{phase_path}.parameter_vals:{param_name}'.

This change is backwards incompatible if users were relying on getting parameter values from the timeseries!

Once this change takes place, parameters will ONLY be available as f'{phase_path}.parameter_vals:{param_name}', not f{phase_path}.timeseries.parameters:{param_name}.

Previous behavior can be recovered by setting the include_timeseries option on the parameter to True.

Example

No response

@robfalck
Copy link
Contributor Author

Closed by #918

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant