Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test_target_update_mapper_from_discontiguous.F90 mapper not strided #643

Open
bcornille opened this issue Nov 30, 2022 · 1 comment
Open
Assignees

Comments

@bcornille
Copy link

Describe the bug
The Fortran version of this test has mapper

        !$omp declare mapper(newvec :: v)&
        !$omp& map(v, v%data(1:v%len))

whereas the C version has mapper

#pragma omp declare mapper(newvec_t v) map(v, v.data[0:v.len:2])

The stride is not present in the Fortran test so does not appear to be testing the same functionality. It would probably be prudent to adjust the test to ensure the intermediate elements are not updated after being set in the target region.

Test that it applies to
test_target_update_mapper_from_discontiguous.F90

Expected behavior
I expect the Fortran version of this test mapper to have mapper

        !$omp declare mapper(newvec :: v)&
        !$omp& map(v, v%data(1:v%len:2))
@spophale
Copy link
Collaborator

The map cannot be stripped. We recently changed our C tests to make the "update" update discontiguous elements of an array.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants