-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formulate learning goals at top of each topic. #83
Comments
I think the note boxes don’t look bad |
Can you try admonition? We also have to check if it is correctly converted to ipynb. |
@jpfeuffer thanks for that link! I tried to find a way to define custom admonitions, but couldn't find an example before, so I tried the Note default. |
also about jupyter compatibility, I didn't expect this, using binder: It turns into simple plain text with Note above (example from a page where a Note was already used before), |
Yes.. unfortunately not supported by pandoc: We would need a custom filter. |
if it is only about the learning goals I think we could also go with the special ignore tag for binder? |
I quickly hacked another pandoc filter: #!/usr/bin/env python
"""
Pandoc filter to convert divs with class="admonition" to ipynb
"""
import sys
from pandocfilters import toJSONFilter, RawBlock, Div, stringify
def html(x):
return RawBlock('html', x)
def admonitions(key, value, format, meta):
if key == 'Div':
[[ident, classes, kvs], contents] = value
if "admonition" in classes and format == "ipynb":
newcontents = [html('<div style="background-color: #BDE5F8; margin: 10px 0px; padding:12px;"><p><i class="fa fa-info-circle"></i> <b>' + stringify(contents[0]) + '</b></p>')] + contents[1:] + [html('</div>')]
return Div([ident, classes, kvs], newcontents)
elif "note" in classes and format == "ipynb":
newcontents = [html('<div style="background-color: #BDE5F8; margin: 10px 0px; padding:12px;"><p><i class="fa fa-info-circle"></i> <b>Note:</b></p>')] + contents + [html('</div>')]
return Div([ident, classes, kvs], newcontents)
if __name__ == "__main__":
toJSONFilter(admonitions) |
But not sure how well that works with nestedness. |
By the way, I could not make the admonitions work without HTML in binder. I don't think it supports the full jupyterBOOK format. |
filter was included in #212 |
What are the remaining documentation todos? |
Add learning goals to top of every "applied"/tutorial section of the pyopenms and maybe also the new openms docs. |
any update here from last sprint? |
Yes. I studied how to put this box and tried a few things. I will try to put this box in each algorithm section by the next week. |
Maybe in a colored box e.g. something like
In this section, you will learn:
The text was updated successfully, but these errors were encountered: