-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Have no FromGraphics on the version last version #20
Comments
Looks like this was removed in the "big bang v4 preview" commit. I believe all the relevant code was in KeyBitmapDrawingExtensions.cs. If the intention was to remove GDI+ dependencies from OpenMacroBoard.SDK, I suspect it would be reasonably simple to build a separate extension package that basically contained that code (assuming licensing etc is okay). |
@dxh-sc Sorry it took me so long to respond. With the switch to v5 I removed some dependencies which were typically "windows-only" and/or not .NET 5 compatible. Yesterday I released v6 and there is now a new package you can add (as @jskeet suggested) to bring back those methods. https://www.nuget.org/packages/OpenMacroBoard.SDK.KeyBitmap.GDI I originally even thought about moving the ImageSharp dependency into a separate package with v6, but that would probably lead to a pretty bad developer experience, because the "naked" Please let me know if that works for you and feel free to reopen the issue or create a new one. |
@wischi-chr: Woot! Glad I was thinking along reasonable lines :) With the new package, I'll have another go at upgrading. (I don't know of any reason I particularly need to upgrade - but being ready for if and when there's Stream Deck+ support would be good :) |
I am using the version of 3.0.0, but after i update to last version 5.0.0, can't build the project now.
I see there have no "KeyBitmap.Create.FromGraphics" on the version 5.0.0.
So there have another method to instead of it?
The text was updated successfully, but these errors were encountered: