Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Suggestion about endif/endforeach #1027

Closed
luigifab opened this issue Jun 7, 2020 · 2 comments · Fixed by #1035
Closed

Suggestion about endif/endforeach #1027

luigifab opened this issue Jun 7, 2020 · 2 comments · Fixed by #1035
Labels
Cleanup: Code style Related to simple CS fixes.

Comments

@luigifab
Copy link
Contributor

luigifab commented Jun 7, 2020 •
edited
Loading

Can I suggest (and make a PR) to replace all variants of endif?

<?php endif; ?>
<?php endif;?>
<?php endif?>
<?php else:?>

By:

<?php endif ?>
<?php else: ?>

(same for endforeach)
Perhaps it's a little duplicate of the "Project Cleanup".
@luigifab luigifab changed the title Suggestion about endif Suggestion about endif/endforeach/endwhile Jun 7, 2020
@luigifab luigifab changed the title Suggestion about endif/endforeach/endwhile Suggestion about endif/endforeach Jun 7, 2020
@sreichel sreichel added the Cleanup: Code style Related to simple CS fixes. label Jun 9, 2020
@colinmollenhour
Copy link
Member

No objection here.

@luigifab luigifab mentioned this issue Jun 10, 2020
Merged
3 tasks
@sreichel sreichel linked a pull request Jul 23, 2020 that will close this issue
Code style (endif endforeach endfor and more) #1035
Merged
3 tasks
@sreichel
Copy link
Contributor

sreichel commented Jul 23, 2020 •
edited
Loading

I'd keep it open until your PR is merged. As soon it is done i'll mark it as "fixed" ...

@sreichel sreichel reopened this Jul 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cleanup: Code style Related to simple CS fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Code style (endif endforeach endfor and more)
3 participants
@colinmollenhour @sreichel @luigifab