Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inoffensive changes in .htaccess #1419

Closed
addison74 opened this issue Jan 23, 2021 · 3 comments
Closed

Inoffensive changes in .htaccess #1419

addison74 opened this issue Jan 23, 2021 · 3 comments
Labels

Comments

@addison74
Copy link
Contributor

In .htaccess file I would recommend inoffensive changes to bring the code to our days:

line 8: php5.ini => php7.ini

line 16: php5 settings => php7 settings

  
############################################
## GoDaddy specific options

#   Options -MultiViews

## you might also need to add this line to php.ini
##     cgi.fix_pathinfo = 1
## if it still doesn't work, rename php.ini to php5.ini

############################################
## default index file

    DirectoryIndex index.php

############################################
## php5 settings

<IfModule mod_php7.c>
@addison74 addison74 added the bug label Jan 23, 2021
@Flyingmana
Copy link
Contributor

we should think about something more flexible here, as php8 now gains traction...
For the comments we can just be a bit more verbose and mention the relation to the version and give examples php7.ini, php8.ini

@addison74
Copy link
Contributor Author

@Flyingmana: Do you consider this line should be in .htaccess #SetEnv MAGE_IS_DEVELOPER_MODE true? If someone would like to debug can easy uncommenting the line.

@addison74
Copy link
Contributor Author

There is a PR for this issue here #1554.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants