Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zip-Release 20.10.0 incomplete or too many items? #4093

Closed
alexh-swdev opened this issue Jul 12, 2024 · 5 comments
Closed

Zip-Release 20.10.0 incomplete or too many items? #4093

alexh-swdev opened this issue Jul 12, 2024 · 5 comments

Comments

@alexh-swdev
Copy link
Contributor

Preconditions (*)

  1. Downlaod the 20.10.0 release zip
  2. deploy

Steps to reproduce (*)

  1. Call a product page

Expected result (*)

  1. No errors, warning, log entries

Actual result (*)

  1. log entry about missing page-cache files
    grafik

In our current live installation as well as in my clean "Upgarde repo", there was no Page-Cache module.
In the magento-lts github, there is also no Page-Cache module
But in the releas zip, there it is:
grafik

Is this on purpose? If so, are there missing files?

There are also community plugins in the zip file (Cm/Cache and Cm/RedisSession) which are not on github. Are those also supposed to be there?

@addison74 addison74 removed the bug label Jul 12, 2024
@addison74
Copy link
Contributor

PageCache shouldn't be there, that module was removed from /app/code/core/Mage some time ago. The ZIP archive contains also the full vendor directory, like you ran the composer install command. @fballiano will provide you more information related to this version.

@alexh-swdev
Copy link
Contributor Author

alexh-swdev commented Jul 12, 2024

The vendor directory is fine. That's why the openmage-vX.Y.Z.zip exists, additionally to source archives. But something seemed to have gone wrong with the rest.

@fballiano
Copy link
Contributor

sorry for the late answer, If I remember correctly those modules are still bundles in OM v19, but they are removed from OM v20

@sreichel
Copy link
Contributor

sreichel commented Jul 20, 2024

PageCache should not be there in v20 at all, but thats not the problem ...

The template/layout filse are not copied to app/design/frontend ...

You can copy it from vendor/openmage/module-mage-pagecache.

There are also community plugins in the zip file (Cm/Cache and Cm/RedisSession) which are not on github. Are those also supposed to be there?

Yes. This should be there.

@sreichel
Copy link
Contributor

sreichel commented Aug 2, 2024

Close it.

With the next release all files should be there.

@sreichel sreichel closed this as completed Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants