-
-
Notifications
You must be signed in to change notification settings - Fork 436
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace money_format function-call #858
Comments
seems to me this class is obsolete i can't find any usage of it. |
@Flyingmana this is not used and a candidate to remove ... isnt it? (#374) |
Is this something we can merge? and use NumberFormatter::formatCurrency() To my understanding the 20.0.x releases are for php 7.4+? |
I've searched all modules from "ModuleFostering" and no one makes use of it. It's a "good first issue" ... just remove it. (There are a few modules that directly use Edit: shouldn't it pop up in syntax check? |
the class \Varien_Filter_Money makes use of the deprecated money_format function.
this should get replaced with NumberFormatter::formatCurrency()
https://www.php.net/manual/en/numberformatter.formatcurrency.php
https://wiki.php.net/rfc/deprecations_php_7_4
The text was updated successfully, but these errors were encountered: