Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace money_format function-call #858

Closed
Flyingmana opened this issue Nov 23, 2019 · 4 comments · Fixed by #1185
Closed

replace money_format function-call #858

Flyingmana opened this issue Nov 23, 2019 · 4 comments · Fixed by #1185
Labels
PHP 7.x Related to PHP 7.x

Comments

@Flyingmana
Copy link
Contributor

the class \Varien_Filter_Money makes use of the deprecated money_format function.

this should get replaced with NumberFormatter::formatCurrency()

https://www.php.net/manual/en/numberformatter.formatcurrency.php
https://wiki.php.net/rfc/deprecations_php_7_4

@Flyingmana Flyingmana added the good first issue easy to solve issues label Nov 23, 2019
@Flyingmana Flyingmana added this to the PHP 7.4 milestone Nov 23, 2019
@roman204
Copy link
Contributor

seems to me this class is obsolete i can't find any usage of it.

@sreichel sreichel added the PHP 7.x Related to PHP 7.x label Jun 12, 2020
@sreichel
Copy link
Contributor

@Flyingmana this is not used and a candidate to remove ... isnt it? (#374)

@sreichel sreichel removed this from the PHP 7.4 milestone Jun 27, 2020
@seansan
Copy link
Contributor

seansan commented Sep 3, 2020

Is this something we can merge? and use NumberFormatter::formatCurrency()

To my understanding the 20.0.x releases are for php 7.4+?

@sreichel
Copy link
Contributor

sreichel commented Sep 3, 2020

@Flyingmana

I've searched all modules from "ModuleFostering" and no one makes use of it. It's a "good first issue" ... just remove it. (There are a few modules that directly use money_format(), so removing it should not harm)

Edit: shouldn't it pop up in syntax check?

@sreichel sreichel added fixed and removed good first issue easy to solve issues labels Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PHP 7.x Related to PHP 7.x
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants