Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix special price for bundle products #1136

Merged
merged 2 commits into from
Aug 9, 2020
Merged

Fix special price for bundle products #1136

merged 2 commits into from
Aug 9, 2020

Conversation

boesbo
Copy link
Contributor

@boesbo boesbo commented Aug 4, 2020 •
edited
Loading

Description (*)

The bug causes: only on the product detail page and in the cart is the price calculated by interpreting the special_price field, which in the Bundle products is a percentage, as if it were a fixed price.

Fixed Issues (if relevant)

  1. Fixes Error calculating the special price for Bundle products #1135

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All automated tests passed successfully (all builds are green)

@boesbo boesbo mentioned this pull request Aug 4, 2020
Closed
@github-actions github-actions bot added the Component: Catalog Relates to Mage_Catalog label Aug 4, 2020
kiatng
kiatng previously approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@kiatng kiatng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tmotyl
Copy link
Contributor

tmotyl commented Aug 7, 2020

@boesbo would usage of "static::" instead of "self::" solve the problem?
The method is still a static method, so it should not be called with "->"

@kiatng kiatng self-requested a review August 7, 2020 08:00
@boesbo
Copy link
Contributor Author

boesbo commented Aug 7, 2020

@boesbo would usage of "static::" instead of "self::" solve the problem?
The method is still a static method, so it should not be called with "->"

! I have tested it and it is fine as "static". I have updated the PR.

@sreichel sreichel added the bug label Aug 7, 2020
sreichel
sreichel approved these changes Aug 7, 2020
View reviewed changes
Copy link
Contributor

@sreichel sreichel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. Tested.

@sreichel sreichel merged commit 4c02c10 into OpenMage:1.9.4.x Aug 9, 2020
@sreichel sreichel added this to the Release 19.4.6 / 20.0.2 milestone Aug 9, 2020
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 20, 2020
@boesbo @edannenberg
[bug-OpenMage#1136] Wrong special price for bundle products when usin…
f65f97a 
…g percentage
edannenberg pushed a commit to edannenberg/magento-lts that referenced this pull request Aug 24, 2020
@boesbo @edannenberg
[bug-OpenMage#1136] Wrong special price for bundle products when usin…
67d7de1 
…g percentage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sreichel sreichel sreichel approved these changes

@tmotyl tmotyl tmotyl approved these changes

@kiatng kiatng Awaiting requested review from kiatng

Assignees
No one assigned
Labels
bug Component: Catalog Relates to Mage_Catalog
Projects
None yet
Milestone
Release 19.4.6 / 20.0.2
Development

Successfully merging this pull request may close these issues.

Error calculating the special price for Bundle products
4 participants
@boesbo @tmotyl @kiatng @sreichel