Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test Dockerfile installation #293

Open
1 of 6 tasks
alejandrosame opened this issue Sep 13, 2020 · 6 comments
Open
1 of 6 tasks

Test Dockerfile installation #293

alejandrosame opened this issue Sep 13, 2020 · 6 comments
Assignees
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Hacktoberfest Open for hacktoberfest 2020 Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase

Comments

@alejandrosame
Copy link
Member

Description

Run tests on containers created through the officially provided Dockerfile.

Type of Test

  • Unit test (e.g. checking a loop, method, or function is working as intended)
  • Integration test (e.g. checking if a certain group or set of functionality is working as intended)
  • Regression test (e.g. checking if by adding or removing a module of code allows other systems to continue to function as intended)
  • Stress test (e.g. checking to see how well a system performs under various situations, including heavy usage)
  • Performance test (e.g. checking to see how efficient a system is as performing the intended task)
  • Other...

Expected Behavior

Before publishing the image to DockerHub, me should run tests on a container built using our Dockerfile.

Additional Context

See #267 (review) for context.

@alejandrosame alejandrosame added Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase labels Sep 13, 2020
@alejandrosame alejandrosame mentioned this issue Sep 13, 2020
6 tasks
@chinmayshah99 chinmayshah99 added the Hacktoberfest Open for hacktoberfest 2020 label Oct 1, 2020
@AbinavRavi
Copy link
Member

Can I take a look at this issue?

@bogomil
Copy link

bogomil commented Jan 5, 2021

Do you still need help with that?

@AbinavRavi
Copy link
Member

I have done the unit tests, I am not sure about how to do the other tests. If anyone can help me it would be useful

@bogomil
Copy link

bogomil commented Jan 6, 2021

I think this is a very good resource on how you could proceed.
https://hackernoon.com/testing-strategies-for-docker-containers-f633e261e75a

I think the need here is to focus on integration tests only ^^

@chinmayshah99
Copy link
Member

Hi @AbinavRavi, if you are facing any issues, please reach out to us on slack in the #lib_pydp channel.

@liabifano
Copy link

Can I take this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue 🎓 Perfect for beginners, welcome to OpenMined! Hacktoberfest Open for hacktoberfest 2020 Type: Testing 🧪 Add testing or improving existing testing of a file, feature, or codebase
Projects
None yet
Development

No branches or pull requests

5 participants