You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Static FL auth checks auth token against supplied model_name and model_version settings, and if token is valid issues worker_id.
Then, worker requests the cycle using worker_id and pygrid checks that such worker_id really exists (authenticated).
The problem is when requesting a cycle, worker may use ANY model_name, model_versions, including different ones than were validated in the auth request. Which means worker may get worker_id auth using unprotected model and then successfully request cycle of protected model.
How to Reproduce
See above.
Expected Behavior
Worker_id must work only for model that worker was authenticated against.
This issue has been marked stale because it has been open 30 days with no activity. Leave a comment or remove the stale label to unmark it. Otherwise, this will be closed in 7 days.
Note: suggested fix is to add new table for FLProcess-Worker authorization.
When worker successfully authenticates for given FL process, we add record to this table.
Then in cycle request, we should check if worker_id is authorized for requested FL process.
madhavajay
added
0.2.x
Relating to the 0.2.x code branch
and removed
Type: Bug 🐛
Some functionality not working in the codebase as intended
Priority: 2 - High 😰
Should be fixed as quickly as possible, ideally within the current or following sprint
Severity: 3 - Medium 😒
Does not cause a failure, impair usability, or interfere with the system
Grid
Issues related to Pygrid project
labels
Jun 8, 2022
Description
Static FL auth checks auth token against supplied model_name and model_version settings, and if token is valid issues
worker_id
.Then, worker requests the cycle using
worker_id
and pygrid checks that suchworker_id
really exists (authenticated).The problem is when requesting a cycle, worker may use ANY model_name, model_versions, including different ones than were validated in the auth request. Which means worker may get worker_id auth using unprotected model and then successfully request cycle of protected model.
How to Reproduce
See above.
Expected Behavior
Worker_id must work only for model that worker was authenticated against.
Screenshots
n/a
System Information
Additional Context
Add any other context about the problem here.
The text was updated successfully, but these errors were encountered: