Skip to content

MIDI Tempo change support #149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Andrew-J-Larson opened this issue Apr 29, 2020 · 6 comments
Open

MIDI Tempo change support #149

Andrew-J-Larson opened this issue Apr 29, 2020 · 6 comments
Labels
C: Enhancement New feature or request
Milestone

Comments

@Andrew-J-Larson
Copy link

Is your feature request related to a problem? Please describe.
Some MIDIs change tempo while mid song, or throughout the song, and importing them into Note Block Studio, they don't currently account for the tempo changes.

Describe the enhancement you'd like
I know there's not going to be a perfect way to implement tempo changes, but there should still be some sort of tempo changes for songs that do change tempo if it's a noticeable type of change in tempo.

Additional context
It shouldn't be too hard to find some MIDIs that do tempo changes in between the song.

@Andrew-J-Larson Andrew-J-Larson added the C: Enhancement New feature or request label Apr 29, 2020
@ShinkoNet
Copy link
Collaborator

It is possible but will require a modification to the NBS format and the way datapack export quantizes the notes. It also won't work with schematic export unless a mod like tickratechanger is incorporated as a command.

But I do want to give it a go in the rewritten version

@Andrew-J-Larson
Copy link
Author

Alrighty... and technically, there is a way without the tickrate changer, just it would require more or less spacing/repeaters for notes going at different tempos

@ShinkoNet
Copy link
Collaborator

that would only work for very specific tempos, again, quantizing the notes as close to the timings as possible. Definitely painful to implement when a mod can just do it (on 1.12, where schematic support currently ends and the mod is avaliable on that version)

@Andrew-J-Larson
Copy link
Author

Andrew-J-Larson commented May 1, 2020 via email

@Bentroen Bentroen added this to the v4.0 milestone May 17, 2020
@OctoFlareDev
Copy link
Collaborator

Added as an experimental feature in 3.9.0.

@gvnfc3
Copy link

gvnfc3 commented May 3, 2022

Where do I turn this Tempo change mid-song option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants