front: remove id from step type, clean arrival and departure consts, modify stopfor as number or undefined

Author: RomainValls

front/src/applications/operationalStudies/types.ts

@@ -18,7 +18,6 @@ import type { SuggestedOP } from 'modules/trainschedule/components/ManageTrainSc
 import type { ArrayElement } from 'utils/types';
 
 export interface Step {
-  id: string;
   uic: number;
   chCode?: string;
   yard?: string;

front/src/modules/trainschedule/components/ImportTrainSchedule/ImportTrainScheduleConfig.tsx

@@ -175,10 +175,7 @@ const ImportTrainScheduleConfig = ({
         const times = ocpTT.getElementsByTagName('times')[0];
         let departureTime = times?.getAttribute('departure') || '';
         let arrivalTime = times?.getAttribute('arrival') || '';
-
-        arrivalTime = times?.getAttribute('arrival') || times?.getAttribute('departure') || '';
         arrivalTime = cleanTimeFormat(arrivalTime);
-        departureTime = times?.getAttribute('departure') || times?.getAttribute('arrival') || '';
         departureTime = cleanTimeFormat(departureTime);
 
         if (!ocpRef) {
@@ -197,7 +194,7 @@ const ImportTrainScheduleConfig = ({
         const formattedArrivalTime = `${startDate} ${arrivalTime}`;
         const formattedDepartureTime = `${startDate} ${departureTime}`;
 
-        let stopFor = 0;
+        let stopFor: number | undefined;
         if (arrivalTime && departureTime) {
           const arrivalDate = new Date(`${startDate}T${arrivalTime}`);
           const departureDate = new Date(`${startDate}T${departureTime}`);
@@ -211,7 +208,7 @@ const ImportTrainScheduleConfig = ({
           name: ocpRef,
           arrivalTime: formattedArrivalTime,
           departureTime: formattedDepartureTime,
-          duration: stopFor > 0 ? stopFor : undefined,
+          duration: stopFor || undefined,
         } as Step;
       })
       .filter((step): step is Step => step !== null);