front: remove some conditions in SimulationResults

- Removed the first condition trainSimulation.status === 'success' to allow the user to see the SpaceTimeChart even if the current selected train is invalid.
- Removed not needed condition on pathproperties to display the spacetimechart

Signed-off-by: Clara Ni <clara.ni@outlook.fr>

Author: clarani

front/src/applications/operationalStudies/views/SimulationResults.tsx

@@ -117,10 +117,6 @@ const SimulationResults = ({
     }
   }, [extViewport]);
 
-  if (!trainSimulation) return null;
-
-  if (trainSimulation.status !== 'success') return null;
-
   return (
     <div className="simulation-results">
       {/* SIMULATION : STICKY BAR */}
@@ -151,7 +147,7 @@ const SimulationResults = ({
           className="simulation-warped-map d-flex flex-row align-items-stretch mb-2"
           style={{ height: manchetteWithSpaceTimeChartHeight }}
         >
-          {projectionData && projectionData.projectedTrains.length > 0 && pathProperties && (
+          {projectionData && projectionData.projectedTrains.length > 0 && (
             <>
               <button
                 type="button"

front/src/modules/timesStops/TimesStopsOutput.tsx

@@ -14,7 +14,7 @@ import TimesStops from './TimesStops';
 import { TableType, type TimeStopsRow } from './types';
 
 type TimesStopsOutputProps = {
-  simulatedTrain: SimulationResponseSuccess;
+  simulatedTrain?: SimulationResponseSuccess;
   trainSummary?: TrainScheduleWithDetails;
   operationalPoints?: PathPropertiesFormatted['operationalPoints'];
   selectedTrainSchedule?: TrainScheduleResult;
@@ -31,7 +31,7 @@ const TimesStopsOutput = ({
   dataIsLoading,
 }: TimesStopsOutputProps) => {
   const enrichedOperationalPoints = useOutputTableData(
-    simulatedTrain,
+    simulatedTrain?.final_output,
     trainSummary,
     operationalPoints,
     selectedTrainSchedule,

front/src/modules/timesStops/hooks/useOutputTableData.ts

@@ -20,7 +20,7 @@ import { formatSchedule } from '../helpers/scheduleData';
 import { type ScheduleEntry, type TimeStopsRow } from '../types';
 
 const useOutputTableData = (
-  { final_output: simulatedTrain }: SimulationResponseSuccess,
+  simulatedTrain?: SimulationResponseSuccess['final_output'],
   trainSummary?: TrainScheduleWithDetails,
   operationalPoints?: PathPropertiesFormatted['operationalPoints'],
   selectedTrainSchedule?: TrainScheduleResult,
@@ -104,7 +104,7 @@ const useOutputTableData = (
   }, [selectedTrainSchedule, path, trainSummary?.pathItemTimes, startDatetime]);
 
   const rows: TimeStopsRow[] = useMemo(() => {
-    if (!operationalPoints || !startDatetime) return [];
+    if (!operationalPoints || !startDatetime || !simulatedTrain) return [];
 
     return operationalPoints.map((op) => {
       const matchingPathStep = pathStepRows.find(