front: reduce and remove unnecessary timeouts for e2e tests

Signed-off-by: maymanaf <med.aymen.naf@gmail.com>

Author: Maymanaf

front/playwright.config.ts

@@ -1,56 +1,29 @@
 import { defineConfig, devices } from '@playwright/test';
-/**
- * Read environment variables from file.
- * https://github.com/motdotla/dotenv
- */
-// require('dotenv').config();
 
-/**
- * See https://playwright.dev/docs/test-configuration.
- */
 export default defineConfig({
   testDir: './tests',
 
-  /* Maximum time one test can run for. */
-  timeout: process.env.CI ? 90 * 1000 : 180 * 1000, // 90 seconds in CI, otherwise 180 seconds
+  timeout: 90_000,
   expect: {
     toHaveScreenshot: { maxDiffPixelRatio: 0.02 },
-    /**
-     * Maximum time expect() should wait for the condition to be met.
-     */
-    timeout: process.env.CI ? 10 * 1000 : 30 * 1000, // 10 seconds in CI, otherwise 30 seconds
+    timeout: 10_000,
   },
 
-  /* Run tests in files in parallel */
   fullyParallel: true,
-  /*
-   * Limit parallelism in CI based on CPU capacity,
-   * running 50% of the available workers when in CI.
-   * Otherwise, run tests with a single worker.
-   */
-  workers: process.env.CI ? '50%' : 1,
-  /* Fail the build on CI if you accidentally left test.only in the source code. */
+  workers: '50%',
   forbidOnly: !!process.env.CI,
-  /* Retry up to 2 times on CI, and 1 time otherwise */
-  retries: process.env.CI ? 2 : 1,
-  /* Shared settings for all the projects below. See https://playwright.dev/docs/api/class-testoptions. */
+  retries: 1,
   use: {
-    /* Maximum time each action such as `click()` can take. Defaults to 0 (no limit). */
-    actionTimeout: 0,
-    /* Base URL to use in actions like `await page.goto('/')`. */
+    navigationTimeout: 30_000,
+    actionTimeout: 15_000,
     baseURL: process.env.BASE_URL || 'http://localhost:4000',
-
-    /* Collect trace and video when retrying the first failed test. See https://playwright.dev/docs/trace-viewer */
     trace: 'on-first-retry',
     video: 'on-first-retry',
-
-    /* Set locale and timezone */
     locale: 'fr',
     timezoneId: 'Europe/Paris',
   },
   reporter: process.env.CI ? 'github' : [['line'], ['html']],
 
-  /* Configure projects for major browsers */
   projects: [
     { name: 'setup', testMatch: 'global-setup.ts', teardown: 'teardown' },
     {

front/tests/003-study-management.spec.ts

@@ -26,6 +26,7 @@ test.describe('Validate the Study creation workflow', () => {
       fr: frTranslations,
     });
   });
+
   test.beforeEach(async ({ page }) => {
     studyPage = new StudyPage(page);
   });

front/tests/006-stdcm.spec.ts

@@ -7,12 +7,6 @@ import { handleAndVerifyInput, waitForInfraStateToBeCached } from './utils';
 import { getInfra, setTowedRollingStock } from './utils/api-setup';
 import type { ConsistFields } from './utils/types';
 
-test.use({
-  launchOptions: {
-    slowMo: 500, // Give the interface time to update between actions
-  },
-});
-
 test.describe('Verify stdcm simulation page', () => {
   test.slow(); // Mark test as slow due to multiple steps
   test.use({ viewport: { width: 1920, height: 1080 } });
@@ -56,7 +50,7 @@ test.describe('Verify stdcm simulation page', () => {
     // Retrieve OSRD language and navigate to STDCM page
     stdcmPage = new STDCMPage(page);
     await page.goto('/stdcm');
-    await page.waitForLoadState('load', { timeout: 30 * 1000 });
+    await page.waitForLoadState('networkidle');
     await stdcmPage.removeViteOverlay();
 
     // Wait for infra to be in 'CACHED' state before proceeding

front/tests/008-train-schedule.spec.ts

@@ -29,6 +29,7 @@ test.describe('Verify train schedule elements and filters', () => {
   const NOT_HONORED_TRAINS = 3;
   const VALID_AND_HONORED_TRAINS = 14;
   const INVALID_AND_NOT_HONORED_TRAINS = 0;
+
   test.beforeAll('Fetch project, study and scenario with train schedule', async () => {
     project = await getProject(trainScheduleProjectName);
     study = await getStudy(project.id, trainScheduleStudyName);

front/tests/011-op-times-and-stops-tab.spec.ts

@@ -101,7 +101,6 @@ test.describe('Times and Stops Tab Verification', () => {
 
       // Setup train configuration and schedule
       await operationalStudiesPage.clickOnAddTrainButton();
-      await page.waitForTimeout(500); // Wait for any async actions to complete
       await operationalStudiesPage.setTrainStartTime('11:22:40');
       await rollingStockPage.selectRollingStock(dualModeRollingStockName);
       await operationalStudiesPage.setTrainScheduleName('Train-name-e2e-test');

front/tests/012-op-simulation-settings-tab.spec.ts

@@ -78,7 +78,6 @@ test.describe('Simulation Settings Tab Verification', () => {
   );
 
   type TranslationKeys = keyof typeof enTranslations;
-  let stabilityTimeout: number;
 
   // Define CellData interface for table cell data
   interface CellData {
@@ -143,10 +142,10 @@ test.describe('Simulation Settings Tab Verification', () => {
       await waitForInfraStateToBeCached(infra.id);
       // Add a new train and set its properties
       await operationalStudiesPage.clickOnAddTrainButton();
-      await operationalStudiesPage.setTrainStartTime('11:22:40');
-      await rollingStockPage.selectRollingStock(improbableRollingStockName);
-      await page.waitForTimeout(stabilityTimeout);
       await operationalStudiesPage.setTrainScheduleName('Train-name-e2e-test');
+      await rollingStockPage.selectRollingStock(improbableRollingStockName);
+      await operationalStudiesPage.setTrainStartTime('11:22:40');
+
       // Perform pathfinding
       await operationalStudiesPage.clickOnRouteTab();
       await routePage.performPathfindingByTrigram('WS', 'SES', 'MWS');
@@ -155,6 +154,7 @@ test.describe('Simulation Settings Tab Verification', () => {
       await scrollContainer(page, '.time-stops-datasheet .dsg-container');
     }
   );
+
   test.afterEach('Delete the created scenario', async () => {
     await deleteScenario(project.id, study.id, scenario.name);
   });
@@ -207,7 +207,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await operationalStudiesPage.clickOnSimulationSettingsTab();
     await opSimulationSettingsPage.deactivateElectricalProfile();
     await opTimetablePage.clickOnEditTrainSchedule();
-    await page.waitForTimeout(stabilityTimeout); // Waiting for the timetable to update due to a slight latency
     await opTimetablePage.getTrainArrivalTime('11:52');
     await opTimetablePage.clickOnScenarioCollapseButton();
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();
@@ -273,7 +272,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await operationalStudiesPage.clickOnSimulationSettingsTab();
     await opSimulationSettingsPage.selectCodeCompoOption('__PLACEHOLDER__');
     await opTimetablePage.clickOnEditTrainSchedule();
-    await page.waitForTimeout(stabilityTimeout);
     await opTimetablePage.getTrainArrivalTime('11:52');
     await opTimetablePage.clickOnScenarioCollapseButton();
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();
@@ -345,7 +343,6 @@ test.describe('Simulation Settings Tab Verification', () => {
     await operationalStudiesPage.clickOnSimulationSettingsTab();
     await opSimulationSettingsPage.activateMarecoMargin();
     await opTimetablePage.clickOnEditTrainSchedule();
-    await page.waitForTimeout(stabilityTimeout);
     await opTimetablePage.getTrainArrivalTime('11:54');
     await opTimetablePage.clickOnScenarioCollapseButton();
     await opOutputTablePage.verifyTimesStopsDataSheetVisibility();

front/tests/013-stdcm-simulation-sheet.spec.ts

@@ -13,12 +13,6 @@ import { getInfra } from './utils/api-setup';
 import { findFirstPdf, verifySimulationContent } from './utils/simulationSheet';
 import type { ConsistFields, Simulation } from './utils/types';
 
-test.use({
-  launchOptions: {
-    slowMo: 500, // Give the interface time to update between actions
-  },
-});
-
 test.describe('Verify stdcm simulation page', () => {
   test.describe.configure({ mode: 'serial' }); // Configure this block to run serially
   test.slow(); // Mark test as slow due to multiple steps
@@ -50,7 +44,7 @@ test.describe('Verify stdcm simulation page', () => {
     // Retrieve OSRD language and navigate to STDCM page
     stdcmPage = new STDCMPage(page);
     await page.goto('/stdcm');
-    await page.waitForLoadState('domcontentloaded', { timeout: 30_000 });
+    await page.waitForLoadState('networkidle');
     await stdcmPage.removeViteOverlay();
 
     // Wait for infra to be in 'CACHED' state before proceeding

front/tests/assets/timeout-const.ts

@@ -0,0 +1,4 @@
+export const LOAD_PAGE_TIMEOUT = 30_000;
+export const SIMULATION_RESULT_TIMEOUT = 30_000;
+export const STDCM_SIMULATION_TIMEOUT = 30_000;
+export const EXPLICIT_UI_STABILITY_TIMEOUT = 1_000;

front/tests/pages/op-input-table-page-model.ts

@@ -65,7 +65,7 @@ class OperationalStudiesInputTablePage {
       .first();
     await rowLocator.waitFor({ state: 'attached' });
     const cell = rowLocator.locator('.dsg-cell').nth(columnIndex);
-    await cell.waitFor({ state: 'visible', timeout: 5000 });
+    await cell.waitFor();
     await cell.dblclick();
 
     // Fill the input field based on the presence of a placeholder
@@ -111,7 +111,7 @@ class OperationalStudiesInputTablePage {
 
     for (let rowIndex = 1; rowIndex < rowCount; rowIndex += 1) {
       const rowCells = this.tableRows.nth(rowIndex).locator('.dsg-cell .dsg-input');
-      await rowCells.first().waitFor({ state: 'visible', timeout: 5000 });
+      await rowCells.first().waitFor();
       const rowValues = await rowCells.evaluateAll((cells) =>
         cells.map((cell) => cell.getAttribute('value'))
       );

front/tests/pages/op-output-table-page-model.ts

@@ -51,7 +51,7 @@ class OperationalStudiesOutputTablePage extends OperationalStudiesTimetablePage
     // Iterate through each active row and extract data based on header mappings
     for (let rowIndex = 1; rowIndex < rowCount; rowIndex += 1) {
       const row = this.tableRows.nth(rowIndex);
-      await row.waitFor({ state: 'visible' });
+      await row.waitFor();
 
       // Extract cells from the current row
       const cells = row.locator('.dsg-cell.dsg-cell-disabled');
@@ -148,11 +148,10 @@ class OperationalStudiesOutputTablePage extends OperationalStudiesTimetablePage
     expect(normalizedActualData).toEqual(normalizedExpectedData);
   }
 
-  // Wait for the Times and Stops simulation data sheet to be fully loaded with a specified timeout (default: 60 seconds)
-  async verifyTimesStopsDataSheetVisibility(timeout = 60 * 1000): Promise<void> {
-    await this.timesStopsDataSheet.waitFor({ state: 'visible', timeout });
-    await this.page.waitForTimeout(1000); // Short delay for stabilization
-    await this.timesStopsDataSheet.scrollIntoViewIfNeeded({ timeout });
+  // Wait for the Times and Stops simulation data sheet to be fully loaded
+  async verifyTimesStopsDataSheetVisibility(): Promise<void> {
+    await this.timesStopsDataSheet.waitFor({ timeout: LOAD_PAGE_TIMEOUT });
+    await this.timesStopsDataSheet.scrollIntoViewIfNeeded();
   }
 }
 

front/tests/pages/op-route-page-model.ts

@@ -3,7 +3,6 @@ import { expect, type Locator, type Page } from '@playwright/test';
 import enTranslations from '../../public/locales/en/operationalStudies/manageTrainSchedule.json';
 import frTranslations from '../../public/locales/fr/operationalStudies/manageTrainSchedule.json';
 import { getTranslations } from '../utils';
-import { clickWithDelay } from '../utils';
 
 class RoutePage {
   readonly page: Page;
@@ -52,6 +51,8 @@ class RoutePage {
 
   readonly missingParamMessage: Locator;
 
+  readonly pathfindingLoader: Locator;
+
   constructor(page: Page) {
     this.page = page;
 
@@ -77,6 +78,7 @@ class RoutePage {
     this.viaModal = page.locator('.manage-vias-modal');
     this.closeViaModalButton = page.getByLabel('Close');
     this.missingParamMessage = page.getByTestId('missing-params-info');
+    this.pathfindingLoader = page.locator('.dots-loader');
   }
 
   // Get the name locator of a waypoint suggestion.
@@ -196,7 +198,7 @@ class RoutePage {
     const expectedDestinationTrigram =
       await this.getDestinationLocatorByTrigram(destinationTrigram).innerText();
     await this.clickSearchByTrigramSubmitButton();
-    await this.page.waitForSelector('.dots-loader', { state: 'hidden' });
+    await this.pathfindingLoader.waitFor({ state: 'hidden' });
     await expect(this.searchByTrigramContainer).not.toBeVisible();
     await expect(this.resultPathfindingDone).toBeVisible();
 
@@ -213,15 +215,14 @@ class RoutePage {
   async clickOnDeleteOPButtons(selectedLanguage: string) {
     // Ensure all buttons are rendered and visible before proceeding
     await Promise.all([
-      this.viaDeleteButton.waitFor({ state: 'visible' }),
-      this.originDeleteButton.waitFor({ state: 'visible' }),
-      this.destinationDeleteButton.waitFor({ state: 'visible' }),
+      this.viaDeleteButton.waitFor(),
+      this.originDeleteButton.waitFor(),
+      this.destinationDeleteButton.waitFor(),
     ]);
 
-    // Click the buttons sequentially with waits to ensure UI stability
-    await clickWithDelay(this.viaDeleteButton);
-    await clickWithDelay(this.originDeleteButton);
-    await clickWithDelay(this.destinationDeleteButton);
+    await this.viaDeleteButton.click();
+    await this.originDeleteButton.click();
+    await this.destinationDeleteButton.click();
     const translations = getTranslations(selectedLanguage, {
       en: enTranslations,
       fr: frTranslations,
@@ -230,15 +231,15 @@ class RoutePage {
       ': {{missingElements}}.',
       ''
     );
-    await this.missingParamMessage.waitFor({ state: 'visible' });
+    await this.missingParamMessage.waitFor();
     const actualMessage = await this.missingParamMessage.innerText();
     expect(actualMessage).toContain(expectedMessage);
   }
 
   // Click the add buttons for the specified via names.
   async clickOnViaAddButtons(...viaNames: string[]) {
     for (const viaName of viaNames) {
-      await clickWithDelay(this.getAddButtonLocatorByViaName(viaName));
+      await this.getAddButtonLocatorByViaName(viaName).click();
       await expect(this.getDeleteButtonLocatorByViaName(viaName)).toBeVisible();
     }
   }