Skip to content

Commit 53a3389

Browse files
committed
github: only group patch upgrades
The idea behind minor-and-patch was to group all uninteresting upgrades together. Indeed, with SemVer, patch and minor upgrades are not supposed to include API breaks, and grouping these together should be a good idea in theory as explained in the GitHub docs [1]. However, in practice this doesn't seem to work well. First, some packages are at version 0.x.y, and minor upgrades often contain breaking changes. Unfortunately there's no way to ask dependabot to not group these unstable dependencies. Another issue is that some minor upgrades do contain some breaking changes (e.g. typescript). Fix these issues by only grouping patch updates, which shoudl still keep the number of PRs to a reasonable number and not include any breaking upgrade. While at it, move the group to the end of the list so that it's only used if none of the other groups match the package which need updating. Indeed, dependabot picks the first group which matches the package [2]. [1]: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/customizing-dependency-updates#grouping-dependabot-updates-into-one-pull-request [2]: https://docs.github.com/en/code-security/dependabot/dependabot-version-updates/configuration-options-for-the-dependabot.yml-file#groups Signed-off-by: Simon Ser <contact@emersion.fr>
1 parent 7282edc commit 53a3389

File tree

1 file changed

+3
-4
lines changed

1 file changed

+3
-4
lines changed

.github/dependabot.yml

+3-4
Original file line numberDiff line numberDiff line change
@@ -33,10 +33,6 @@ updates:
3333
schedule:
3434
interval: "weekly"
3535
groups:
36-
minor-and-patch:
37-
update-types:
38-
- "minor"
39-
- "patch"
4036
nivo:
4137
patterns:
4238
- "@nivo/*"
@@ -50,6 +46,9 @@ updates:
5046
patterns:
5147
- "vitest"
5248
- "@vitest/*"
49+
patch:
50+
update-types:
51+
- "patch"
5352
commit-message:
5453
prefix: "front:"
5554
open-pull-requests-limit: 100

0 commit comments

Comments
 (0)