fixup! front: improve page object structure and optimize project language handling for e2e tests

Author: Maymanaf

front/tests/002-project-management.spec.ts

@@ -11,15 +11,15 @@ test.describe('Validate the Operational Study Project workflow', () => {
   let project: Project;
   let projectPage: ProjectPage;
 
-  test.beforeEach('Navigate to the projects page', async ({ page }) => {
+  test.beforeEach(async ({ page }) => {
     projectPage = new ProjectPage(page);
-    // Create a project
-    project = await createProject(generateUniqueName(projectData.name));
-    await page.goto('/operational-studies/projects');
   });
 
   /** *************** Test 1 **************** */
-  test('Create a new project', async () => {
+  test('Create a new project', async ({ page }) => {
+    // Go to projects page
+    await page.goto('/operational-studies/projects');
+
     // Define a unique project name for the test
     const projectName = generateUniqueName(projectData.name);
 
@@ -48,7 +48,11 @@ test.describe('Validate the Operational Study Project workflow', () => {
   });
 
   /** *************** Test 2 **************** */
-  test('Update an existing project', async () => {
+  test('Update an existing project', async ({ page }) => {
+    // Create a project
+    project = await createProject(generateUniqueName(projectData.name));
+    await page.goto('/operational-studies/projects');
+
     // Open the created project by name using the project page model
     await projectPage.openProjectByTestId(project.name);
 
@@ -81,7 +85,11 @@ test.describe('Validate the Operational Study Project workflow', () => {
   });
 
   /** *************** Test 3 **************** */
-  test('Delete a project', async () => {
+  test('Delete a project', async ({ page }) => {
+    // Create a project
+    project = await createProject(generateUniqueName(projectData.name));
+    await page.goto('/operational-studies/projects');
+
     // Find the project by name and delete it using the page model
     await projectPage.openProjectByTestId(project.name);
     await projectPage.deleteProject(project.name);

front/tests/003-study-management.spec.ts

@@ -34,7 +34,6 @@ test.describe('Validate the Study creation workflow', () => {
   test('Create a new study', async ({ page }) => {
     // Navigate to project page
     await page.goto(`/operational-studies/projects/${project.id}`);
-    // Set translations based on the language
     const studyName = `${studyData.name} ${uuidv4()}`; // Unique study name
     const todayDateISO = new Date().toISOString().split('T')[0]; // Get today's date in ISO format
     const expectedDate = formatDateToDayMonthYear(todayDateISO);

front/tests/006-stdcm.spec.ts

@@ -48,7 +48,6 @@ test.describe('Verify stdcm simulation page', () => {
   });
 
   test.beforeEach('Navigate to the STDCM page', async ({ page }) => {
-    // Retrieve OSRD language and navigate to STDCM page
     [stdcmPage, stdcmLinkedTrainPage] = [new STDCMPage(page), new STDCMLinkedTrainPage(page)];
     await page.goto('/stdcm');
     await page.waitForLoadState('networkidle');

front/tests/013-stdcm-simulation-sheet.spec.ts

@@ -39,7 +39,6 @@ test.describe('Verify stdcm simulation page', () => {
   });
 
   test.beforeEach('Navigate to the STDCM page', async ({ page }) => {
-    // Retrieve OSRD language and navigate to STDCM page
     stdcmPage = new STDCMPage(page);
     await page.goto('/stdcm');
     await page.waitForLoadState('networkidle');

front/tests/pages/op-route-page-model.ts

@@ -156,7 +156,7 @@ class RoutePage {
     await this.deleteItineraryButton.click();
   }
 
-  // Verify that no route is selected and displays appropriate messages based on language.
+  // Verify that no route is selected and displays appropriate messages.
   async verifyNoSelectedRoute() {
     const translations = getTranslations({
       en: enTranslations,

front/tests/pages/stdcm-page-model.ts

@@ -499,7 +499,7 @@ class STDCMPage extends HomePage {
     await expect(this.toleranceOriginArrival).not.toBeVisible();
   }
 
-  // Fill and verify destination details based on selected language
+  // Fill and verify destination details
   async fillAndVerifyDestinationDetails() {
     const {
       input,
@@ -594,15 +594,16 @@ class STDCMPage extends HomePage {
   async fillAndVerifyViaDetails({
     viaNumber,
     ciSearchText,
-    language,
   }: {
     viaNumber: number;
     ciSearchText: string;
-    language?: string;
   }): Promise<void> {
     const { PASSAGE_TIME, SERVICE_STOP, DRIVER_SWITCH } = VIA_STOP_TYPES;
     const { serviceStop, driverSwitch } = VIA_STOP_TIMES;
-    const translations = language === 'English' ? enTranslations : frTranslations;
+    const translations = getTranslations({
+      en: enTranslations,
+      fr: frTranslations,
+    });
     const warning = this.getViaWarning(viaNumber);
     // Helper function to fill common fields
     const fillVia = async (selectedSuggestion: Locator) => {