Skip to content

Commit 950c4ac

Browse files
committed
front: drop StdcmResultsOperationalPointsList type
This just adds an unnecessary indirection. Directly use an array to make it clear that we manipulate one (as opposed to an object). Signed-off-by: Simon Ser <contact@emersion.fr>
1 parent 7282edc commit 950c4ac

File tree

3 files changed

+6
-8
lines changed

3 files changed

+6
-8
lines changed

front/src/applications/stdcm/components/StdcmResults/StdcmResultsTable.tsx

+2-2
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import cx from 'classnames';
55
import { useTranslation } from 'react-i18next';
66

77
import type {
8-
StdcmResultsOperationalPointsList,
8+
StdcmResultsOperationalPoint,
99
StdcmSimulationInputs,
1010
StdcmSuccessResponse,
1111
} from 'applications/stdcm/types';
@@ -15,7 +15,7 @@ type SimulationTableProps = {
1515
stdcmData: StdcmSuccessResponse;
1616
consist: StdcmSimulationInputs['consist'];
1717
isSimulationRetained: boolean;
18-
operationalPointsList: StdcmResultsOperationalPointsList;
18+
operationalPointsList: StdcmResultsOperationalPoint[];
1919
onRetainSimulation: () => void;
2020
};
2121

front/src/applications/stdcm/types.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -57,12 +57,10 @@ export type SimulationReportSheetProps = {
5757
consist: StdcmSimulationInputs['consist'];
5858
simulationReportSheetNumber: string;
5959
mapCanvas?: string;
60-
operationalPointsList: StdcmResultsOperationalPointsList;
60+
operationalPointsList: StdcmResultsOperationalPoint[];
6161
};
6262

63-
export type StdcmResultsOperationalPointsList = StdcmResultsOperationalPoint[];
64-
65-
type StdcmResultsOperationalPoint = {
63+
export type StdcmResultsOperationalPoint = {
6664
opId: string;
6765
positionOnPath: number;
6866
time: string | null;

front/src/applications/stdcm/utils/formatSimulationReportSheet.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import type { SimulationResponse } from 'common/api/osrdEditoastApi';
22
import { interpolateValue } from 'modules/simulationResult/SimulationResultExport/utils';
33
import type { SuggestedOP } from 'modules/trainschedule/components/ManageTrainSchedule/types';
44

5-
import type { StdcmResultsOperationalPointsList } from '../types';
5+
import type { StdcmResultsOperationalPoint } from '../types';
66

77
function generateRandomString(length: number): string {
88
return Array.from({ length }, () => Math.floor(Math.random() * 10)).join('');
@@ -113,7 +113,7 @@ export function getOperationalPointsWithTimes(
113113
operationalPoints: SuggestedOP[],
114114
simulation: Extract<SimulationResponse, { status: 'success' }>,
115115
departureTime: string
116-
): StdcmResultsOperationalPointsList {
116+
): StdcmResultsOperationalPoint[] {
117117
const { positions, times } = simulation.final_output;
118118
const pathDepartureTime = new Date(departureTime).toLocaleTimeString().substring(0, 5);
119119

0 commit comments

Comments
 (0)