front: change arrivalDate type to Date in isArrivalDateInSearchTimeWindow

Signed-off-by: SarahBellaha <sarah.bellaha@sncf.fr>

Author: SarahBellaha

front/src/applications/stdcm/components/StdcmForm/StdcmOpSchedule.tsx

@@ -61,7 +61,7 @@ const StdcmOpSchedule = ({
     useMemo(() => {
       const isArrivalDateValid =
         opTimingData?.arrivalDate &&
-        isArrivalDateInSearchTimeWindow(opTimingData.arrivalDate, searchDatetimeWindow);
+        isArrivalDateInSearchTimeWindow(new Date(opTimingData.arrivalDate), searchDatetimeWindow);
       return {
         arrivalDate:
           opTimingData && isArrivalDateValid

front/src/utils/__tests__/date.spec.ts

@@ -116,7 +116,7 @@ describe('extractDateAndTimefromISO', () => {
 
 describe('isArrivalDateInSearchTimeWindow', () => {
   it('should return true if searchDatetimeWindow is undefined', () => {
-    const result = isArrivalDateInSearchTimeWindow('2024-08-01T10:00:00Z', undefined);
+    const result = isArrivalDateInSearchTimeWindow(new Date('2024-08-01T10:00:00Z'), undefined);
     expect(result).toBe(true);
   });
 
@@ -125,7 +125,10 @@ describe('isArrivalDateInSearchTimeWindow', () => {
       begin: new Date('2024-08-01T00:00:00Z'),
       end: new Date('2024-08-02T00:00:00Z'),
     };
-    const result = isArrivalDateInSearchTimeWindow('2024-08-01T10:00:00Z', searchDatetimeWindow);
+    const result = isArrivalDateInSearchTimeWindow(
+      new Date('2024-08-01T10:00:00Z'),
+      searchDatetimeWindow
+    );
     expect(result).toBe(true);
   });
 
@@ -134,7 +137,10 @@ describe('isArrivalDateInSearchTimeWindow', () => {
       begin: new Date('2024-08-01T00:00:00Z'),
       end: new Date('2024-08-02T00:00:00Z'),
     };
-    const result = isArrivalDateInSearchTimeWindow('2024-07-30T23:59:59Z', searchDatetimeWindow);
+    const result = isArrivalDateInSearchTimeWindow(
+      new Date('2024-07-30T23:59:59Z'),
+      searchDatetimeWindow
+    );
     expect(result).toBe(false);
   });
 });

front/src/utils/date.ts

@@ -218,18 +218,17 @@ export function extractDateAndTimefromISO(arrivalTime: string, dateFormat: strin
 /**
  * Checks if the given arrival date falls within the specified search time window.
  *
- * @param {string | Date} arrivalTime - The arrival time, which can be a Date object or an ISO string that will be parsed into a Date object.
+ * @param {Date} arrivalDate - The arrival time, which is a Date object.
  * @param {{ begin: Date; end: Date } | undefined} searchDatetimeWindow - An object containing the start and end dates of the search window. If undefined, the function will return true.
  * @returns {boolean} - Returns true if the arrival date is within the search time window, or if the search time window is undefined. Returns false otherwise.
  */
 export function isArrivalDateInSearchTimeWindow(
-  arrivalTime: string | Date,
+  arrivalDate: Date,
   searchDatetimeWindow?: { begin: Date; end: Date }
 ) {
   if (!searchDatetimeWindow) {
     return true;
   }
-  const arrivalDate = typeof arrivalTime === 'string' ? new Date(arrivalTime) : arrivalTime;
   return arrivalDate >= searchDatetimeWindow.begin && arrivalDate <= searchDatetimeWindow.end;
 }