sarah's review

Author: sim51

front/src/modules/trainschedule/components/ManageTrainSchedule/Map.tsx

@@ -91,6 +91,7 @@ const Map = ({
   const terrain3DExaggeration = useSelector(getTerrain3DExaggeration);
   const { viewport, mapSearchMarker, mapStyle, showOSM, layersSettings } = useSelector(getMap);
   const mapRef = useRef<MapRef | null>(null);
+  const mapContainer = useMemo(() => mapRef.current?.getContainer(), [mapRef.current]);
 
   const pathGeometry = useMemo(
     () => geometry || pathProperties?.geometry,
@@ -99,15 +100,14 @@ const Map = ({
 
   const mapViewport = useMemo(() => {
     if (isReadOnly && pathGeometry) {
-      const mapContainer = mapRef.current?.getContainer();
       return computeBBoxViewport(bbox(pathGeometry), viewport, {
         width: mapContainer?.clientWidth,
         height: mapContainer?.clientHeight,
         padding: 60,
       });
     }
     return viewport;
-  }, [isReadOnly, pathGeometry, viewport, mapRef]);
+  }, [isReadOnly, pathGeometry, viewport, mapContainer]);
 
   const [mapIsLoaded, setMapIsLoaded] = useState(false);
 
@@ -219,15 +219,14 @@ const Map = ({
       type: 'LineString',
     };
     if (points.coordinates.length > 2) {
-      const mapContainer = mapRef.current?.getContainer();
       const newViewport = computeBBoxViewport(bbox(points), mapViewport, {
         width: mapContainer?.clientWidth,
         height: mapContainer?.clientHeight,
         padding: 60,
       });
       dispatch(updateViewport(newViewport));
     }
-  }, [pathGeometry, simulationPathSteps, mapRef]);
+  }, [pathGeometry, simulationPathSteps, mapContainer]);
 
   return (
     <>