Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Picking some rolling stocks triggers unwanted warning #10306

Closed
axrolld opened this issue Jan 9, 2025 · 1 comment · Fixed by #10313 or #10418
Closed

Picking some rolling stocks triggers unwanted warning #10306

axrolld opened this issue Jan 9, 2025 · 1 comment · Fixed by #10313 or #10418
Assignees
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:major Major severity bug

Comments

@axrolld
Copy link
Contributor

axrolld commented Jan 9, 2025

What happened?

Picking MAL100 as a towed rolling stocks triggers this:
Image

There seems to be a tolerance problem here because the value is correct.

What did you expect to happen?

I'm expecting no warning if the value is within the acceptable range.

How can we reproduce it (as minimally and precisely as possible)?

  1. Select MAL100 as a towed rolling stock

On which environments the bug occurs?

Recette (SNCF)

On which browser the bug occurs?

Google Chrome

OSRD version (top right corner Account button > Informations)

fdfd8ac

@axrolld axrolld added kind:bug Something isn't working area:front Work on Standard OSRD Interface modules module:stdcm Short-Term DCM severity:major Major severity bug labels Jan 9, 2025
@SharglutDev SharglutDev self-assigned this Jan 9, 2025
@axrolld
Copy link
Contributor Author

axrolld commented Jan 16, 2025

Same thing happened with this rolling stock:

Image

After investigating with @clarani it seems like the actual wieght of this rs is 80,7t, but the pre-filled value is 80, so it's technically lower than the bound, which makes sense.

A good way to fix this would be:

  • keeping the bounds with the real values
  • round the pre-filled value from the top: changing 80,7 into 81, but also 80,01 into 81

@axrolld axrolld reopened this Jan 16, 2025
@axrolld axrolld closed this as completed Jan 16, 2025
@axrolld axrolld changed the title Picking MAL100 as a towed rolling stocks triggers unwanted warning Picking some rolling stocks triggers unwanted warning Jan 16, 2025
@axrolld axrolld reopened this Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:front Work on Standard OSRD Interface modules kind:bug Something isn't working module:stdcm Short-Term DCM severity:major Major severity bug
Projects
None yet
2 participants