Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The default font sizes for the website are actually a bit tiny. #336

Open
thadguidry opened this issue May 22, 2024 · 5 comments
Open

The default font sizes for the website are actually a bit tiny. #336

thadguidry opened this issue May 22, 2024 · 5 comments

Comments

@thadguidry
Copy link
Member

thadguidry commented May 22, 2024

We can increase the font-size globally quite easily so that things "just work" across all devices and systems.

Currently the default for Docusaurus Theme Classic behind the scenes are

--ifm-font-size-base: 100%
--ifm-code-font-size: 90%;

But ideally should be something like
--ifm-font-size-base: 110% or slightly larger depending on opinions.

This can be added into the /src/css/custom.css file like so:

:root {
  --ifm-font-size-base: 110%;
  --ifm-code-font-size: 100%;
  --ifm-color-primary: #25c2a0;
  etc.
}
@thadguidry thadguidry added enhancement Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. labels May 22, 2024
@anushatomar13
Copy link

Hi @thadguidry I would like to work on this issue.
It would be great if you could assign it to me!

@wetneb
Copy link
Sponsor Member

wetneb commented May 22, 2024

@anushatomar13 I think for a change like this, what's mostly important is to gather consensus around the move: the implementation itself is rather straightforward. So I would not rush to open a PR for this to let other people voice their opinions.

@wetneb wetneb removed the Good First Issue Indicates issues suitable for newcomers to design or coding, providing a gentle introduction. label May 22, 2024
@wetneb
Copy link
Sponsor Member

wetneb commented May 22, 2024

Side comment: Overall I am not sure about using "Good First Issue" in this repository - it could mislead newcomers into thinking that they are working on OpenRefine itself… In the past we've had people contributing here with the intention to use those PRs to apply for Outreachy/GSoC, but of course those contributions don't demonstrate their ability to make changes on OpenRefine so that did not support their applications very well.

@thadguidry
Copy link
Member Author

@wetneb My thoughts of adding "Good First Issue" on website features we want or need (now or future) is so that we continue to pull in contributors. I think we can be flexible here for the website and documentation. And I also think we can easily navigate folks applying for Outreachy/GSoC.

@magdmartin
Copy link
Member

I tested with --ifm-font-size-base: 110% by editing the style directly in Chrome DevTool. Overall, it looks good except for the H1, which are really large.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants