New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Move wiki_tools function that use a mwclient.Site argument to osw.wtsite.WtSite as methods #98

Open

LukasGold opened this issue Nov 28, 2024 · 0 comments

Assignees

Labels

Contributor

LukasGold commented Nov 28, 2024

osw.wtsite relies on an import of wiki_tools. Therefore, it is not possible to create wiki_tools functions that accept both, mwclient.Site and osw.wtsite.WtSite objects.
Further, it is rather non-intuitive to have to access the OSW.site._site attribute to get a mwclient.Site object which can be passed to the wiki_tool functions in questions.

Bottomline: We should do a refactor to move most functionality of wiki_tools that have a mwclien.Site attribute to osw.wtsite.WtSite methods

LukasGold added the enhancement label

LukasGold assigned LukasGold and SimonStier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment