-
Notifications
You must be signed in to change notification settings - Fork 549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Welcome/Tutorial Window stays and buttonclick only reloads Window #1708
Comments
I am have a similar problem on a Ubuntu Linux system. Tutorial window pops up and can only be hidden by clicking on the Openshot program window. But it will pop back up after saving a file or several other operations. The "NEXT" button does not work. It really is annoying for that "Tutorial" window to keep popping up, but won't do anything. Version 2.4.1 Ubuntu 18.04 |
Hey there, could you please switch to the latest daily PPA? A fix to this issue was pushed in recently (and we still need to test it). Also, for manjaro, perhaps trying out the latest daily AppImages should work. Please do not use the RC builds but the other ones (ones that do not end with rc-1 or rc-2 or rc-3). Hope to hear the results soon! |
2.4.1-dev1 still contains this behavior |
Still happening with the latest non-rc AppImage that I see at https://www.openshot.org/download/ OpenShot-v2.4.1-170-g2ff63e3-9ae61e50-f32c7c30-x86_64.AppImage (21 June 2018) running on: |
Gentlemen, I have good news for you! Currently, a fix is in progress. And hopefully, this fix will be released in If you want to follow the developments regarding the solution to this problem, you can follow it here. However, I would advise you not to comment about your problems there, as it is a thread for code reviews and not for user support. Hope that helps! Please do keep on loving and supporting OpenShot! |
Just in case you can't run the AppImage, please try this work-around. Hope that helps! |
Well, crap. That means the QDockWidget isn't being rendered transparent on your system, for some reason. It's configured transparent, though... I wonder why it isn't rendering that way? Hmm, XFCE you say... I wonder if the WM (openbox, I think?) supports compositing? If not, we may be in trouble with the transparent window background... but then again, I wouldn't have expected the previous code to work either. And I can't imagine it's lacking a compositor in 2018. Out of curiosity, was the tutorial popup transparent in the previous version? It may have been hard to tell, since that window didn't have a side arrow, so you'd only have seen a tiny bit of black poking out from behind the rounded corners, like in the lower-left corner of the one on your screenshot. If the old tutorials weren't transparent either, then it may just be an issue with the compositing on XFCE. If they were, I'll have to figure out why the new ones aren't being rendered the same way. Perhaps I missed something in how I set up the drawing canvas that gets defaulted to black on XFCE, but "clear" on Gnome Shell. (Thanks for taking the time to try that out, BTW, @k4yaman .) Oh, and one more thing: Do you happen to know what video card your system has? |
Hello, |
nod Well, basically everything is different with the new tutorial, the way the popups are managed was completely restructured. I must've missed something in the setup code, but I'll keep looking. The first "Welcome" popup, that one was also non-transparent in the new code, right? And even though it doesn't have an arrow, there was still a wide black bar to the left? Just making sure I have a complete picture of the layout issues, pardon the pun. ("...What pun?" is the correct answer there.) |
Yes, and I am additionally able to change the window size on all edges except the top one. And on the left side I can change the size on the left side of the black bar |
Yeah, that part's perfectly normal — a consequence of how the tutorials are managed now is that they can be resized on some systems. Normally it's pretty difficult to do. (You have to find a 1-pixel-wide invisible hairline window edge.) But your system cheats with that opaque window background, which makes it a lot easier to find. |
Well, I just made a couple of changes that might help. Though to be honest I'm not very confident in that, the documentation says the flags I just added should already be set automatically. |
screencaps for |
Hmmm... curiouser and curiouser. Thanks @meoso , so it's apparently not a universal thing. Now, the question is, what is it about @k4yaman 's system that's different, and is there anything OpenShot can do to account for it? (One idea I've already thought of is simply not doing transparent tutorial popups, if we can detect that they won't be supported. The tutorial could easily render itself as a simple non-transparent window, without the blue arrows or rounded corners, in situations where that's necessary.) |
Just moving a couple of @meoso 's XFCE 4.10 / |
@k4yaman - Good sir, in order to test the changes made by @ferdnyc, could you please clone the repos and test it from the source for the time being, please? It seems the builds are failing currently. However, should it work, I will post the AppImages for testing here as fast as I can. But then again, it might take a few more days... Here is the developers guide, BTW. Update: The CI system seems to keep on failing for some reason. I think it's broken. Only our BDFL can fix it. So I suggest you proceed with testing from the source. Sorry for the inconvenience. |
Testing "from source" only works if you have a working libopenshot and libopenshot-audio installed somewhere, which any users running from AppImages don't have. I don't know anything about Manjaro, is that something that's easy enough to obtain? (As long as the libraries from a 2.4.2 release are installed on the system, I agree — running |
Hmm... the developers page does get into getting all the libraries installed on Ubuntu, at least. I wonder if finding their equivalents in majaro would be that hard (it probably would be though). The guide is pretty well documented, nevertheless... It seems like our only choice now. Because buildkite. :D |
The developers guide details building the libraries! We should never point any endusers at that guide! Ubuntu users can just install |
Well... in my defense he does use majaro - the arch linux for the common man. 😄 I wouldn't want to do this, either. It's just that currently, we have no choice... 😞 |
I tried the AppImage, still same Issue. I even tried to build the whole thing, but my ffmpeg is just the wrong one. (I don't think the PPA is working on arch) I also changed the xfwm settings to the ones mentioned in the screenshot without any luck. When I install libopenshot and libopenshot-audio and run |
Unfortunately for @peanutbutterandcrackers I just today think I finally found the transparency issue and fixed it, too late to make it into that AppImage. Perhaps if we get a next one. He's also seen the same issue, though, so hopefully he can test it locally first.
Hmmm. That should work. I've never actually seen that before, since I don't even know how it's possible to get mismatched versions of Qt5 on the same system. The page you linked to says that the 'libopenshot' package was built with QtMultimedia 5.11.1 ( From that error it sounds like your system is using Qt 5.11.0. ( |
I really hope we can sort something out for his local build first. That'd be great. Could you use a ffmpeg 4 patch in this PR for the issue regarding ffmpeg? In the meantime, something has come up with the PR and once that has been resolved, I will try my best to get you an AppImage as fast as I can... |
Good news, the branch test/ferd_tutorial2 is working without any Problems. Good work guys, thank you. (Forgot to update my System, it's a rolling release system) |
@k4yaman - Awesome! Thank you for the good news, sir! Could you please also write a quick gist regarding how to compile openshot from source on arch linux? That should be quite helpful for future degubbers/developers/testers. |
Describe the bug
Welcome/Tutorial window stays and buttonclick only reloads window on first start. You can right click in the task bar and close but it reopens again.
Startet with starter which has: openshot-qt %F
With Terminal sart: openshot-qt
starts the tutorial but still popup stays open
after clicking excessively on the buttons they start to apply
regards
The text was updated successfully, but these errors were encountered: