Centralize osiType defaulting, warn in case of default

Signed-off-by: Pierre R. Mai <pmai@pmsf.de>

Author: pmai

qc_ositrace/checks/osirules/osirules_checker.py

@@ -361,7 +361,7 @@ def run_checks(config: Configuration, result: Result) -> None:
     fallback_version = tuple(
         [int(s) for s in osirules_constants.OSI_FALLBACK_VERSION.split(".")]
     )
-    expected_type_name = config.get_config_param("osiType") or "SensorView"
+    expected_type_name = config.get_config_param("osiType")
 
     trace = OSITrace(config.get_config_param("InputFile"), expected_type_name)
 

qc_ositrace/main.py

@@ -92,7 +92,6 @@ def main():
     config = Configuration()
     if args.default_config:
         logging.info("Using default configuration")
-        config.set_config_param("osiType", "SensorView")
         config.register_checker_bundle(checker_bundle_name=constants.BUNDLE_NAME)
     else:
         config.load_from_file(xml_file_path=args.config_path)
@@ -122,6 +121,12 @@ def main():
             value=str(args.result_file),
         )
 
+    if config.get_config_param("osiType") is None:
+        config.set_config_param("osiType", "SensorView")
+        logging.warning(
+            "No OSI Type specified, defaulting to SensorView. This may lead to unexpected results if it does not match the actual type."
+        )
+
     logging.info("Running OSI Trace checker bundle")
 
     result = run_checker_bundle(config=config)