Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test for valid neuroml2 #21

Closed
borismarin opened this issue Jun 3, 2014 · 4 comments
Closed

test for valid neuroml2 #21

borismarin opened this issue Jun 3, 2014 · 4 comments

Comments

@borismarin
Copy link
Member

No description provided.

@borismarin borismarin changed the title test fot valide neuroml2 test for valid neuroml2 Jun 3, 2014
@pgleeson
Copy link
Member

Have added backends jNeuroML_validate and jNeuroML_validatev1 for this.

@borismarin
Copy link
Member Author

Shouldn't we always validate nml for any jnml-based backend? Without the need for separated backeds? This way, it seems that we will be delegating functionality to backend names, and the number of different b-e will grow just to implement specific features.
If there's a nml target involved, I suggest trying to validate agains both schemata (v1,v2) and, if it fails for both, stop testing.

@borismarin borismarin reopened this Jul 18, 2014
@borismarin
Copy link
Member Author

It can maybe fit within #7

@pgleeson
Copy link
Member

pgleeson commented Sep 3, 2014

There can be some cases where an nml file is known to be not valid, e.g. included new elements, but jNeuroML still treats them as LEMS & jNeuroML successfully runs.

If a user wants to explicitly state that all nml files are valid they can easily add a test file like:
https://github.com/OpenSourceBrain/ACnet2/blob/master/neuroConstruct/generatedNeuroML2/.test.validate.omt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants