-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Table Title for Excel Output #569
Conversation
Commit a3c65cf and d6d6c11 allow table generated by Before the two commits,
or
And right now, after the fix:
or
Likewise, for |
LGTM, +1 for merging |
@GoFroggyRun can you handle these merge conflicts in this PR and the one in #564? |
@brittainhard , thanks for the reminder, this PR is good to go. |
Currently TaxBrain Excel output files do not include Table title. As demonstrated below:
This PR adds a function
addTit
, withinext.buttons.excelHtml5
, to insert title information to excel output (excel button only, CSV and copy buttons have different logic and thus will be fixed separately). Selector is used to extract proper title names.This PR generates excel files with title information included as follow:
Could you review? @MattHJensen @brittainhard