Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad syntax in requirements file. #603

Merged
merged 1 commit into from
Aug 3, 2017
Merged

Bad syntax in requirements file. #603

merged 1 commit into from
Aug 3, 2017

Conversation

brittainhard
Copy link
Contributor

No description provided.

@martinholmer
Copy link
Contributor

@brittainhard, Why are you pinning numba to an out-of-date version?

numba is not pinned in Tax-Calculator, so having numba==0.33.0 here may cause conflicts.

iMac2:tax-calculator mrh$ conda search numba | grep 0.3 | tail -20
                             0.32.0              np112py35_0  defaults        
                             0.32.0              np112py36_0  defaults        
                             0.33.0              np111py27_0  defaults        
                             0.33.0              np111py35_0  defaults        
                             0.33.0              np111py36_0  defaults        
                             0.33.0              np112py27_0  defaults        
                             0.33.0              np112py35_0  defaults        
                             0.33.0              np112py36_0  defaults        
                             0.34.0              np110py27_0  defaults        
                             0.34.0              np110py35_0  defaults        
                             0.34.0              np111py27_0  defaults        
                             0.34.0              np111py34_0  defaults        
                             0.34.0              np111py35_0  defaults        
                             0.34.0              np111py36_0  defaults        
                             0.34.0              np112py27_0  defaults        
                             0.34.0              np112py35_0  defaults        
                             0.34.0              np112py36_0  defaults        
                          *  0.34.0              np113py27_0  defaults        
                             0.34.0              np113py36_0  defaults        
                             0.34.0              np113py35_5  defaults        

@hdoupe

@brittainhard
Copy link
Contributor Author

@martinholmer we are using that numba version because we were getting deployment failures with the latest one. The latest numba was causing errors, and our application isn't working with it, so we needed to hard-code it.

@brittainhard brittainhard merged commit 72a44da into master Aug 3, 2017
@brittainhard brittainhard deleted the bhard/fix_yaml branch August 3, 2017 21:42
@martinholmer
Copy link
Contributor

@brittainhard said:

We are using that numba version because we were getting deployment failures with the latest one. The latest numba was causing errors, and our application isn't working with it, so we needed to hard-code it.

This is a very bad strategy. What you need to do is fix the TaxBrain code so it works with numba 0.34.0. A couple of changes to Tax-Calculator needed to be made recently when new versions of packages became available: see Tax-Calculator PR 1470 by @talumbau and Tax-Calculator PR 1473 by me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants