Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Page Clean Up #611

Merged
merged 3 commits into from
Sep 18, 2017
Merged

Web Page Clean Up #611

merged 3 commits into from
Sep 18, 2017

Conversation

GoFroggyRun
Copy link
Contributor

This PR tries to close issue #584.

  1. CCC has been added to "OUR PRODUCTS":

screen shot 2017-08-08 at 12 04 41 pm

  1. Twitter link has been added. (FB and LinkedIn links are still pending)

  2. The "APP" link on the bottom of home page has been fixed, which directs to TaxBrain page.

@brittainhard Please review.

cc @MattHJensen

@brittainhard
Copy link
Contributor

@GoFroggyRun @MattHJensen I think this PR brings up the problem in #494 that I noticed a while back. The link says "apps" but only goes to TaxBrain and not CCC.

I think we might need to add some code that handles this. We can simply add two more links, one for taxbrain and one for ccc. Any thoughts?

I also noticed that the "Our Mission" part of the about page is missing.

@GoFroggyRun
Copy link
Contributor Author

@brittainhard said:

I think we might need to add some code that handles this. We can simply add two more links, one for taxbrain and one for ccc.

This approach makes sense to me since TaxBrain is no longer the only app we have.

And:

I also noticed that the "Our Mission" part of the about page is missing.

This part, along with "Our History" section, can be filled when context become available.

@MattHJensen
Copy link
Contributor

MattHJensen commented Aug 23, 2017

I also noticed that the "Our Mission" part of the about page is missing.

When I go to http://www.ospc.org/about/, I do see content in the "our mission" and "our history" sections.

*The content is, however, out of date. I hope to address it soon.

We can simply add two more links, one for taxbrain and one for ccc.

That makes sense to me.

@brittainhard brittainhard merged commit d51ae84 into ospc-org:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants