Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change title name for liability table #621

Merged
merged 1 commit into from
Sep 18, 2017

Conversation

GoFroggyRun
Copy link
Contributor

Per requests in #545, the title name for liability table is not right when user exports the table via "Print" button.

Beforehand, the title name was "Welcome to TaxBrain". After this PR, the title name, when being printed, would be more informative, that is also consistent with the title name on the result page.

The new page generated from the "Print" button for liability table will look like:

screen shot 2017-08-15 at 11 51 44 am

@brittainhard Could you please review?

cc @MattHJensen

@brittainhard
Copy link
Contributor

@GoFroggyRun is this ready for review?

@GoFroggyRun
Copy link
Contributor Author

@brittainhard yep. Please take a look.

@brittainhard brittainhard merged commit 5f52120 into ospc-org:master Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants