-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor submit_reform for quick-calc submission case #655
Conversation
@brittainhard PR #655 is ready for review. |
This is working. @hdoupe why the large refactoring job. What does the |
@brittainhard |
@@ -602,9 +632,49 @@ def submit_micro(request, pk): | |||
model.tax_result = None | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The data is already parsed into a TaxSaveInputs
object so that means that there is no need to go through the request
parsing logic in submit_reform
.
@hdoupe need to fix these merge conflicts. |
@brittainhard Sorry about that. I should have checked this earlier. I'll run this locally and make sure it works. |
@brittainhard Just ran it locally. I submitted a quick-calc and a full calculation from there and everything looks good. |
LGTM, merging. |
Closes #654