-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename macro elasticity label and remove dropdown menu in its result page #684
Conversation
@GoFroggyRun, your pull request #684 looks good as far as it goes. |
@martinholmer thanks for catching this. I changed the title to |
@GoFroggyRun said:
Well, I guess the terms for different parts of a table can be confusing. I would say that in commit 06f3747 you changed the row label, not the title. What I would call the title is right above the year table row. What I was asking you to do was to change The current title is simply incorrect. The table does not contain elasticities (the one assumed elasticity was specified on the Macro-Elasticity input parameter page) but rather contains the proportional change in GDP caused by the interaction of the assumed elasticity and the change in the average marginal tax rate. Sorry about the confusion in my earlier request. But we do need to change the incorrect title. |
Commit b27c6fa looks great! Thanks, @GoFroggyRun, and sorry for my confusing suggestions. |
@martinholmer my bad, I thought your intention were to un-symbolize the |
@GoFroggyRun LGTM. Is this ready to merge? |
Yep @hdoupe |
This PR fixes #673 and #683. The new page/button would look something like:
and
and finally