Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "news.ospc.org" link bug #729

Merged
merged 1 commit into from
Nov 4, 2017
Merged

Conversation

GoFroggyRun
Copy link
Contributor

This PR closes #727.

The Policy Brain app is not able to find news.ospc.org without supplying a full hyper link, for the reason that the blog (news) page is hosted somewhere else outside the app.

There's no way for me to test on my local (the previous link works just fine on local as well as on test app). I used console to substitute HTML elements on ospc.org by hard-coding, and it seems that, after making the following changes, the website has no problem accessing news.ospc.org.

@hdoupe @MattHJensen

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 3, 2017

@GoFroggyRun This seems like it would fix the problem. But, it's tough to tell if this solves the problem since it worked on the test app before. I can give it a try and see if it works. What do you think?

@GoFroggyRun
Copy link
Contributor Author

@hdoupe said:

But, it's tough to tell if this solves the problem since it worked on the test app before.

Indeed, that's why I tried to test the changes in this PR using ospc.org.
It's still hard, however, to guarantee that this approach will resolve the problem. Let's give it a try first.

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 3, 2017

@GoFroggyRun I agree that we should give it a try. I'll do a deploy tomorrow and see what happens.

@GoFroggyRun
Copy link
Contributor Author

@hdoupe sounds good. Thanks!

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 3, 2017

No problem. Thanks for providing the quick fix.

I think a better long-term fix would be to get https://news.ospc.org to work. However, there are some extra steps you have to go through to do so with S3. See this article for example: https://medium.com/@sbuckpesch/setup-aws-s3-static-website-hosting-using-ssl-acm-34d41d32e394

@hdoupe hdoupe merged commit bc5ab08 into ospc-org:master Nov 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants