-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Web page clean ups and bug fixes #741
Conversation
@hdoupe can we have this PR included in the new update? |
To drop the footer from the news.ospc.org page, you will have to edit the blog-posts repo. This PR just drops the footer from the pages in this repo. It appears that #737 isn't fully resolved either since the link https://ospc.org/hello still hangs. As @MaxGhenis pointed out in #737 it should be https://www.ospc.org/hello/. Once #737 is resolved, we can merge this. I'll open an issue for this in the blog-posts repo. |
@@ -33,12 +33,12 @@ <h2>Overview</h2> | |||
<li><strong>Step 6.</strong> Share your results! The link to every results page is static and will never change. Send them around.</li> | |||
</ul> | |||
|
|||
<p> Throughout this process, if you have a question about how to use TaxBrain or interpret the results, if you want to make a suggestion for making the interface or underlying models better, or if you discover a bug, please <a href = '//list.ospc.org/mailman/listinfo/users_list.ospc.org' target="_blank">join our mailing list</a> and send a message or <a href = '//ospc.org/hello' target="_blank">leave a note for the OSPC team</a>.</p> | |||
<p> Throughout this process, if you have a question about how to use TaxBrain or interpret the results, if you want to make a suggestion for making the interface or underlying models better, or if you discover a bug, please <a href = '//list.ospc.org/mailman/listinfo/users_list.ospc.org' target="_blank">join our mailing list</a> and send a message or <a href = '//www.ospc.org/hello' target="_blank">leave a note for the OSPC team</a>.</p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just tested it and it didn't seem to work correctly. I'll take another look though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strange. Both links are working on my local.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just checked again, and it worked. Sorry about that.
Looks good to me. Thanks @GoFroggyRun |
This PR closes #731 #732 #737.