Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels and titles dynamically update and initial loading bug fixed #742

Merged
merged 1 commit into from
Nov 21, 2017

Conversation

hayleefay
Copy link
Contributor

This PR fixes issue #728 by correcting the initial loading values of the assets shown in the hover-over and dynamically updating the title of the plots and the x-axis label.

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 20, 2017

Thanks @hayleefay. I'm reviewing this now.

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 21, 2017

@hayleefay I merged the master branch into your branch and reset the environment which moved your branch to a newer version of taxcalc.

I then received the following error when I tried to do a run:
screen shot 2017-11-21 at 9 29 52 am

Here's the traceback from the log:

[2017-11-21 09:27:24,995: WARNING/MainProcess] user mods:
[2017-11-21 09:27:24,996: WARNING/MainProcess] {u'btax_depr_10yr_tax_Switch': False, u'btax_depr_3yr_gds_Switch': u'T', u'btax_betr_pass': 0.0, u'btax_depr_5yr_tax_Switch': False, u'btax_depr_allyr_tax_Switch': False, u'btax_depr_5yr_gds_Switch': u'T', u'btax_depr_15yr_tax_Switch': False, u'btax_depr_25yr_gds_Switch': u'T', u'btax_depr_5yr_ads_Switch': False, u'btax_depr_5yr': False, u'btax_betr_entity_Switch': False, u'btax_depr_3yr_tax_Switch': False, u'btax_depr_25yr_tax_Switch': False, u'btax_depr_27_5yr': False, u'btax_depr_39yr_gds_Switch': u'T', u'btax_depr_39yr': False, u'btax_depr_10yr': False, u'btax_depr_20yr_gds_Switch': u'T', u'btax_depr_3yr_ads_Switch': False, u'btax_depr_15yr_ads_Switch': False, u'btax_depr_7yr_ads_Switch': False, u'btax_depr_20yr_ads_Switch': False, u'btax_depr_15yr': False, u'btax_depr_27_5yr_tax_Switch': False, u'btax_depr_39yr_tax_Switch': False, u'btax_depr_39yr_ads_Switch': False, u'btax_depr_allyr_gds_Switch': False, u'btax_depr_15yr_gds_Switch': u'T', u'btax_depr_20yr': False, u'btax_depr_10yr_ads_Switch': False, u'btax_depr_25yr': False, u'btax_depr_27_5yr_ads_Switch': False, u'btax_betr_corp': 0.3, u'btax_depr_25yr_ads_Switch': False, u'btax_depr_27_5yr_gds_Switch': u'T', u'btax_depr_3yr': False, u'btax_depr_7yr_gds_Switch': u'T', u'btax_depr_20yr_tax_Switch': False, u'btax_depr_7yr': False, u'btax_depr_10yr_gds_Switch': u'T', u'btax_depr_7yr_tax_Switch': False, u'btax_depr_allyr_ads_Switch': False}
[2017-11-21 09:27:38,117: ERROR/MainProcess] Task celery_tasks.btax_async[2da1f1ea-f4fb-4981-843d-b452305f0c44] raised unexpected: ValueError('Records data missing one or more MUST_READ_VARS',)
Traceback (most recent call last):
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/celery/app/trace.py", line 374, in trace_task
    R = retval = fun(*args, **kwargs)
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/celery/app/trace.py", line 629, in __protected_call__
    return self.run(*args, **kwargs)
  File "/Users/henrydoupe/Documents/PolicyBrain/deploy/taxbrain_server/celery_tasks.py", line 156, in btax_async
    tables = runner_json_tables(**user_mods)
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/btax/front_end_util.py", line 23, in runner_json_tables
    out = runner(test_run,start_year,iit_reform,**user_params)
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/btax/execute.py", line 58, in runner
    base_output_by_asset, base_output_by_industry = run_btax(test_run,True,start_year,{},**econ_params)
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/btax/run_btax.py", line 93, in run_btax
    parameters = params.get_params(test_run,baseline,start_year,iit_reform,**user_params)
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/btax/parameters.py", line 169, in get_params
    indiv_rates = get_rates(baseline,start_year,iit_reform)
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/btax/get_taxcalc_rates.py", line 101, in get_rates
    reform=reform)
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/btax/get_taxcalc_rates.py", line 55, in get_calculator
    records1 = Records()
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/taxcalc/records.py", line 119, in __init__
    self._read_data(data, exact_calculations)
  File "/anaconda/envs/aei_dropq/lib/python2.7/site-packages/taxcalc/records.py", line 428, in _read_data
    raise ValueError(msg)
ValueError: Records data missing one or more MUST_READ_VARS

This could be an error on my end if my puf version is off, but I just downloaded a clean copy. So, I'm not sure how that would happen.

@hdoupe
Copy link
Collaborator

hdoupe commented Nov 21, 2017

@hayleefay this looks good. The problems I listed above were on my end. Sorry about that. Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants