-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restore "Print" button for elasticity output page #860
Conversation
@GoFroggyRun proposed this Macro Elasticity Simulation output table: Give the row label on the left, I wound seem as if the row of |
@martinholmer said:
Thanks for pointing this out @martinholmer. I agree that the extra row of % seems redundant. Would it be sensible to eliminate the row in the original table as well? I.e., modifying the table to something like: Personally, I find the new table more concise yet as informative as the old one. |
@GoFroggyRun, Your latest version of the table looks good. Thanks. |
Thanks @GoFroggyRun. The new version of the table looks good to me, too. |
@GoFroggyRun Can you push the changes that remove the percent symbol? Should be good to go once you do that. |
@hdoupe thanks for the reminder. I was hoping to include "Copy" button as well in this PR. However, its layout seems a little bit tricky. I think it's a good idea to merge this PR first. I'll have "copy" button in another PR once finished. This PR is considered complete after 6dd54ea, @hdoupe could you review? |
LGTM. Thanks @GoFroggyRun for the contribution and @martinholmer for the review! |
I removed all non-functional buttons for the elasticity result page for the moment. I also plan to permanently get rid of the "Save As" drop-down whose options don't make much sense in my opinion.
I re-organized the div element a bit so that the table can be properly accessed, and was able to have the "Print" button semi-working. Here's how the page would look like:
A new window would pop-out with the same content in the table that allows you to print/save. I plan to polish the table layout a bit which would complete this button.