Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore "Print" button for elasticity output page #860

Merged
merged 4 commits into from
Mar 27, 2018

Conversation

GoFroggyRun
Copy link
Contributor

I removed all non-functional buttons for the elasticity result page for the moment. I also plan to permanently get rid of the "Save As" drop-down whose options don't make much sense in my opinion.

I re-organized the div element a bit so that the table can be properly accessed, and was able to have the "Print" button semi-working. Here's how the page would look like:

screen shot 2018-03-22 at 4 36 24 pm
A new window would pop-out with the same content in the table that allows you to print/save. I plan to polish the table layout a bit which would complete this button.

@martinholmer
Copy link
Contributor

@GoFroggyRun proposed this Macro Elasticity Simulation output table:

screen shot 2018-03-22 at 4 36 24 pm

Give the row label on the left, I wound seem as if the row of % symbols below the top year row is redundant.

@GoFroggyRun
Copy link
Contributor Author

@martinholmer said:

Give the row label on the left, I wound seem as if the row of % symbols below the top year row is redundant.

Thanks for pointing this out @martinholmer. I agree that the extra row of % seems redundant. Would it be sensible to eliminate the row in the original table as well? I.e., modifying the table to something like:

screen shot 2018-03-22 at 5 15 16 pm

Personally, I find the new table more concise yet as informative as the old one.
cc @hdoupe @MattHJensen

@martinholmer
Copy link
Contributor

@GoFroggyRun, Your latest version of the table looks good. Thanks.

@hdoupe
Copy link
Collaborator

hdoupe commented Mar 23, 2018

Thanks @GoFroggyRun. The new version of the table looks good to me, too.

@hdoupe
Copy link
Collaborator

hdoupe commented Mar 26, 2018

@GoFroggyRun Can you push the changes that remove the percent symbol? Should be good to go once you do that.

@GoFroggyRun GoFroggyRun changed the title [WIP] Restore functional buttons for elasticity output page Restore functional buttons for elasticity output page Mar 26, 2018
@GoFroggyRun GoFroggyRun changed the title Restore functional buttons for elasticity output page Restore "Print" button for elasticity output page Mar 26, 2018
@GoFroggyRun
Copy link
Contributor Author

GoFroggyRun commented Mar 26, 2018

@hdoupe thanks for the reminder. I was hoping to include "Copy" button as well in this PR. However, its layout seems a little bit tricky. I think it's a good idea to merge this PR first. I'll have "copy" button in another PR once finished.

This PR is considered complete after 6dd54ea, @hdoupe could you review?

@hdoupe
Copy link
Collaborator

hdoupe commented Mar 27, 2018

LGTM. Thanks @GoFroggyRun for the contribution and @martinholmer for the review!

@hdoupe hdoupe merged commit 6d8a740 into ospc-org:master Mar 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants