Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back-end for not_avail.html page #875

Merged
merged 7 commits into from
Mar 29, 2018
Merged

Conversation

hdoupe
Copy link
Collaborator

@hdoupe hdoupe commented Mar 28, 2018

This PR adds renders the not_avail.html page (see #874) when an error is thrown while rendering simulation results.

For TaxBrain:

screen shot 2018-03-28 at 11 36 05 am

For CCC:

screen shot 2018-03-28 at 11 36 43 am

@hdoupe
Copy link
Collaborator Author

hdoupe commented Mar 28, 2018

After the previous commits the pages look like:

screen shot 2018-03-28 at 11 46 29 am

screen shot 2018-03-28 at 11 47 28 am

@hdoupe
Copy link
Collaborator Author

hdoupe commented Mar 28, 2018

@GoFroggyRun @MattHJensen can you review?

@GoFroggyRun
Copy link
Contributor

GoFroggyRun commented Mar 29, 2018

@hdoupe looks good to me! Thanks for updating the back-end part.

Once this got merged, I'll have a separate PR open that breaks up the headers.

@hdoupe
Copy link
Collaborator Author

hdoupe commented Mar 29, 2018

Great, thanks for the review @GoFroggyRun

@hdoupe hdoupe merged commit 1d98b54 into ospc-org:master Mar 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants