Use current default start year if start year was not saved #876
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some older runs, the start year was not saved. So, when you try to go to the edit parameters page from the
not_avail.htmlpage and don't have a start year, the link looks like:/taxbrain/edit/100/?start_year=Noneand you get the following error:The production database has about 700 out of 30000 runs with out a start year and all of them were created in 2014 or 2015. This PR uses the current default start year as the start year value. This may not be the most accurate. Perhaps, using the year from the creation date is more accurate. But, that solution adds more complexity to the code for a small sample of the runs. Also, I feel like using the current start year is the most transparent option. I'm open to other ideas though.