Convert to Python 3 #886
Merged
Convert to Python 3 #886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The heroku buildpack needs to be updated, too. I plan to do this in a follow up PR. We currently use a build-pack that was forked from the official buildpack: https://github.com/heroku-python/conda-buildpack. Also, the worker nodes need to be upgraded to Python 3. Note that the webapp and the worker nodes can be out-of-sync since the worker nodes run as separate processes. I will update this in a follow up PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts PolicyBrain to Python 3. So far, I have only run the Python 2to3 module. I'm pretty impressed with the initial results...only 22 out of the 172 tests failed. However, even once all the tests are passing, we will have to take care to test the app thoroughly before deploying it.