Various code style improvements, mainly to TaxBrain views #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hdoupe
reviewed
Jun 14, 2018
webapp/apps/taxbrain/views.py
Outdated
|
|
||
| if all([j == 'YES' for j in jobs_ready]): | ||
| if all((j == 'YES' for j in jobs_ready)): | ||
| results = dropq_compute.dropq_get_results(normalize(job_ids)) |
There was a problem hiding this comment.
@lucassz what's your motivation for using a tuple instead of a list?
There was a problem hiding this comment.
This is a generator expression, which should be more efficient. In this case, it can fail quicker, if one item is not 'YES', without needing to generate the whole list. Although, now that I look at the spec, it seems as though the second set of parentheses isn't needed.
There was a problem hiding this comment.
Ah, neat. Yep, looks like you don't need the second-set of parentheses.
There was a problem hiding this comment.
Thanks for the explanation.
|
LGTM, thanks for the contribution @lucassz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various suggestions for changes to the TaxBrain views file, mainly to meet PEP8 guidelines and for general cleanup. Also, some list comprehensions are changed to generator expressions. I'm looking forward to feedback about whether these are too many or too few changes for this purpose.