Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cropper.prepare raises an exception when one rectangle does not overlap the ROI #39

Open
carlosandujar opened this issue Dec 6, 2022 · 2 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@carlosandujar
Copy link

Depending on the input, some images might not overlap the largest internal rectangle (see example).

Cropper.prepare raises an exception, but it would be more desirable to just ignore non-overlapping rectangles, or return their indices so that they can be removed as when subsetting to the largest component of the graph.

sample_mask

@lukasalexanderweber
Copy link
Member

Thanks for reporting the issue! I was not aware of that.

@lukasalexanderweber lukasalexanderweber added bug Something isn't working good first issue Good for newcomers labels Dec 6, 2022
@lukasalexanderweber
Copy link
Member

another use case with images which can be used to test:

StitchingError: Rectangles do not overlap!

#172 (comment)

06_lir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants