Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zfsiostats.py and cache #228

Closed
sersim opened this issue Oct 28, 2015 · 4 comments
Closed

zfsiostats.py and cache #228

sersim opened this issue Oct 28, 2015 · 4 comments
Labels

Comments

@sersim
Copy link

sersim commented Oct 28, 2015

If I have cache devices in my ZFS storage pool I get errors:
2015-10-28 21:20:34,887 tcollector[14141] WARNING: zfsiostats.py: File ".../tcollector/collectors/0/zfsiostats.py", line 167, in main
2015-10-28 21:20:34,887 tcollector[14141] WARNING: zfsiostats.py: "expecting last state T_SEPARATOR, now got %s" % ltype
2015-10-28 21:20:34,887 tcollector[14141] WARNING: zfsiostats.py: AssertionError: expecting last state T_SEPARATOR, now got 5

Looks like it doesn't expect to find the cache section

My workaround is adding these lines:
elif line.startswith("cache"):
assert ltype in (T_POOL, T_DEVICE),
"expecting last state T_POOL or T_DEVICE, now got %s" % ltype
ltype = T_LEG

@johann8384 johann8384 added the bug label Feb 1, 2016
@johann8384
Copy link
Member

PR welcome.

@johann8384 johann8384 added this to the 1.3.1 milestone Feb 5, 2016
@johann8384
Copy link
Member

@sersim Can you see if the changes from #256 fixed your issue?

@benrubson
Copy link
Contributor

Bug reproduced here.
I'm trying to correct it.

@benrubson
Copy link
Contributor

#266 solves this 👍

@johann8384 johann8384 removed this from the 1.3.1 milestone Mar 16, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants