-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a headless browser to allow content to be rendered dynamically #138
Comments
Note that using a headless browser is probably more user-friendly, but will require quite a lot of extra processing time to fetch the documents. In this particular case, browsing the source code of https://vimeo.com/privacy, there is a From my experience, there is probably a balance to be found between adding too much processing logic or having a user-friendly way of fetching policies (at the expense of performance). Considering the current code base, I'd rather be in favor of the latter. |
FYI, we noticed this is the same requirement for Wish, see https://github.com/TomHouriezDGE/CGUs/blob/f9818cfa6b218ff4cc6862b170a4a3285d05b1a8/services/Wish.json (requires a headless browser). |
After discussing with @Ndpnt @LucasVerneyDGE @clementbiron @TomHouriezDGE, we agreed that:
Great, can't wait to land this feature! 😃 |
Implemented in #183 |
For example, Vimeo renders its content with a script.
See https://github.com/ambanum/CGUs-versions/blob/master/Vimeo/Privacy%20Policy.md
The text was updated successfully, but these errors were encountered: