Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check Code checks code even if it hasn't changed #314

Open
2 tasks done
davidvandusen opened this issue Feb 21, 2022 · 0 comments
Open
2 tasks done

Check Code checks code even if it hasn't changed #314

davidvandusen opened this issue Feb 21, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@davidvandusen
Copy link
Member

Expected behaviour

The api and webapp ESLint and Prettier checks (and any other module specific checks) only run when files from those modules have changed.

Actual behaviour

ESLint and Prettier run against both api and webapp even if no files from those modules have changed.

Details and resources

If the code checks were broken out into separate workflows, a paths filter could be used to determine whether they should run.

https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#example-including-paths

Checklist

  • This issue is linked to the appropriate project.
  • This issue has appropriate labels.
@davidvandusen davidvandusen added the enhancement New feature or request label Feb 21, 2022
@davidvandusen davidvandusen self-assigned this Mar 8, 2022
@davidvandusen davidvandusen removed their assignment Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant